Skip to content

Conversion for zoom and microns per pixel#2059

Merged
adaudon merged 2 commits into
mainfrom
oav_param_fix
May 18, 2026
Merged

Conversion for zoom and microns per pixel#2059
adaudon merged 2 commits into
mainfrom
oav_param_fix

Conversation

@adaudon
Copy link
Copy Markdown
Contributor

@adaudon adaudon commented May 15, 2026

In oav_parameters.py, there was an error when OAVConfigBeamCenter would run get_parameters() whenever the user clicked on the Move on Click button.
The um_xy and bc_xy had different types for their keys.
um_xy was giving integer strings while bc_xy was giving float strings.

So a change was made to convert um_xy to float strings which allowed the code to work as the keys now matched.

The issue might be related to the move to the daq config server?

@adaudon adaudon requested a review from a team as a code owner May 15, 2026 15:56
@adaudon adaudon requested review from jacob720 and noemifrisina May 15, 2026 15:56
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.13%. Comparing base (5824ccd) to head (8958030).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2059   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files         337      337           
  Lines       13079    13080    +1     
=======================================
+ Hits        12966    12967    +1     
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacob720
Copy link
Copy Markdown
Contributor

jacob720 commented May 18, 2026

I think the type issues should also be fixed by this DiamondLightSource/daq-config-server#174, which means the zoom config will have it's own pydantic model with specified types.

@adaudon
Copy link
Copy Markdown
Contributor Author

adaudon commented May 18, 2026

Once daq-config-server has that PR pushed, can remove this if needed to help prevent unintentional bugs. Not sure when it'll be pushed though so merging change for now.

@adaudon adaudon merged commit abbe6e9 into main May 18, 2026
11 checks passed
@adaudon adaudon deleted the oav_param_fix branch May 18, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants