Conversion for zoom and microns per pixel#2059
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2059 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 337 337
Lines 13079 13080 +1
=======================================
+ Hits 12966 12967 +1
Misses 113 113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I think the type issues should also be fixed by this DiamondLightSource/daq-config-server#174, which means the zoom config will have it's own pydantic model with specified types. |
jacob720
approved these changes
May 18, 2026
Contributor
Author
|
Once daq-config-server has that PR pushed, can remove this if needed to help prevent unintentional bugs. Not sure when it'll be pushed though so merging change for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In oav_parameters.py, there was an error when OAVConfigBeamCenter would run get_parameters() whenever the user clicked on the Move on Click button.
The um_xy and bc_xy had different types for their keys.
um_xy was giving integer strings while bc_xy was giving float strings.
So a change was made to convert um_xy to float strings which allowed the code to work as the keys now matched.
The issue might be related to the move to the daq config server?