Update to ophyd-async 0.17a4#1979
Conversation
…iamondLightSource/dodal into update_dodal_ophyd_async_v0.17a1
|
I'm going to make a new release of |
Thanks @oliwenmandiamond! It's expected that the
I think for the tetramms we can just change it back. For i11 it looks like the enum on |
Just checked this on the beamline, we're connecting to everything that we expect to connect to ( |
DominicOram
left a comment
There was a problem hiding this comment.
I think for the tetramms we can just change it back.
It's not quite that easy. After more investigation I think the underlying issue is that we're using https://github.com/epics-modules/quadEM/tree/master for controlling the tetramms. This doesn't inherit from ADDriver but instead from asynNDArrayDriver. I think there may also be a number of other problems such as the comment in the old driver saying:
# tetramm never goes idle really, actually it is always acquiring
# so need to wait for the capture to finish instead
but we're using ADArmLogic now, which does wait for the state to go to idle. Generally probably needs more thought and testing on the beamline
|
This is such a big review I think we're going to have to break it up. For now I've put off the mythen issue and then:
|
|
The Odin for Jungfrau is not ready yet, so it needs to keep using Nick's writer |
|
@DominicOram am happy with the electron analyser bits. I will need to fix them though as gone out of date now |
Then does someone in @DiamondLightSource/developers-mx-daq have capacity to update the commissioning JF to the new version? |
|
I have confirmed that |
DominicOram
left a comment
There was a problem hiding this comment.
I'm happy that this now works for my beamlines. I have tested on i15-1 and will test on i22 tomorrow. If I see errors on i22 I'll make new PRs
|
@DominicOram @CoePaul @rtuck99 @jacob720 @Relm-Arrowny Can
|
As per James' comment above we can't remove it and it is being used by i24. I will write some tests.
Sure, I will do this too |
WIP
OOO until 1/4/26
Downstream changes for mx-bluesky: