Refactor: Secure literal search and defensive scope handling#4492
Open
mhdnazrul wants to merge 3 commits into
Open
Refactor: Secure literal search and defensive scope handling#4492mhdnazrul wants to merge 3 commits into
mhdnazrul wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This Pull Request addresses two critical security and stability issues found in the search functionality of both the Install (Apps tabs) and Tweaks tabs.
1. Fix: Apps Search Wildcard Injection & Scope Handling
[,*,{) triggered PowerShell wildcard errors, causing terminal crashes and UI freezes..IndexOf()and handled the$syncobject's scope more defensively to ensure it's always accessible.2. Fix: Tweaks Search Hardening & PS 5.1 Compatibility
-likeoperators with safe literal matching.? :syntax).+to-prefixes).Visual Proof
A. Apps Tab (Install Tab)
Before (The Error):

After (The Fix):

B. Tweaks Tab
Before (The Error):

After (The Fix):

Issue related to PR