Skip to content

simplify Compile.ps1 by alot#4484

Open
GabiNun2 wants to merge 13 commits into
ChrisTitusTech:mainfrom
GabiNun2:patch-5
Open

simplify Compile.ps1 by alot#4484
GabiNun2 wants to merge 13 commits into
ChrisTitusTech:mainfrom
GabiNun2:patch-5

Conversation

@GabiNun2
Copy link
Copy Markdown
Contributor

@GabiNun2 GabiNun2 commented May 13, 2026

Changes:

  • Removed removing winutil.ps1 at the start because it's unneeded Set-Content overrides it
  • Removed progress output since execution is now almost instant
  • Removed $Arguments because winutil.ps1 has arguments not Complie.ps1
  • Removed preprocessing
  • Removed syntax check for winutil.ps1 since errors are already shown during execution
  • Removed Set-ExecutionPolicy for -Run argument because if you can run complie.ps1 you dont need to change Set-ExecutionPolicy

@GabiNun2 GabiNun2 requested a review from ChrisTitusTech as a code owner May 13, 2026 19:49
@GabiNun2 GabiNun2 marked this pull request as draft May 13, 2026 19:49
@GabiNun2 GabiNun2 marked this pull request as ready for review May 13, 2026 19:53
@GabiNun2 GabiNun2 changed the title simplify Compile.ps1 alot simplify Compile.ps1 by alot May 14, 2026
Copy link
Copy Markdown
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial idea for preprocessing was that it will cleanup and standardize the code (like removing spaces at end of lines and capitalization for common functions).

In practice, I do find it more annoying than helpful. I think removing it is the right call, but lets do this on stream as I'd like more feedback.

@ChrisTitusTech ChrisTitusTech added the new feature New feature or request label May 15, 2026
@GabiNun2
Copy link
Copy Markdown
Contributor Author

The initial idea for preprocessing was that it will cleanup and standardize the code (like removing spaces at end of lines and capitalization for common functions).

In practice, I do find it more annoying than helpful. I think removing it is the right call, but lets do this on stream as I'd like more feedback.

you shouldn't write bad code anyways :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants