Skip to content

[NetAppFiles] pool size enhancement, examples, and default networkfeture#33387

Open
audunn wants to merge 3 commits into
Azure:devfrom
audunn:release-Microsoft.NetApp-2026-03-01
Open

[NetAppFiles] pool size enhancement, examples, and default networkfeture#33387
audunn wants to merge 3 commits into
Azure:devfrom
audunn:release-Microsoft.NetApp-2026-03-01

Conversation

@audunn
Copy link
Copy Markdown
Member

@audunn audunn commented May 15, 2026

Related command

Description

Testing Guide

History Notes
[NetAppFiles] az netappfiles pool create: Added new --size-in-bytes parameter accepting bytes directly (549755813888 for 512 GiB or any positive multiple of 1099511627776 for 1 TiB). --size and --size-in-bytes are mutually exclusive.
[NetAppFiles] az netappfiles pool update: Added new --size-in-bytes parameter accepting bytes directly (549755813888 for 512 GiB or any positive multiple of 1099511627776 for 1 TiB). --size and --size-in-bytes are mutually exclusive.
[NetAppFiles]: az netappfiles volume create: Parameter --network-features default value changed from Basic to Standard .


This checklist is used to make sure that common guidelines for a pull request are followed.

Copilot AI review requested due to automatic review settings May 15, 2026 16:43
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 15, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the NetApp Files command module to support more flexible capacity pool sizing (including a bytes-based size parameter with mutual exclusivity), expands scenario coverage around pool sizing and CMK volume creation, and changes the default --network-features for volume creation to Standard. It also updates the account create help examples to clarify quoting for CMK + user-assigned identity scenarios across shells.

Changes:

  • Add --size-in-bytes for az netappfiles pool create/update and enforce --size vs --size-in-bytes mutual exclusivity; validate/convert sizes to bytes and append an AFEC registration hint on relevant service errors.
  • Add/extend scenario tests and recordings for pool sizing defaults and --size-in-bytes, plus an end-to-end CMK volume create flow.
  • Change az netappfiles volume create --network-features default from Basic to Standard, and refine account create CMK examples.

Reviewed changes

Copilot reviewed 12 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/azure-cli/azure/cli/command_modules/netappfiles/custom.py Implements pool size argument reshaping/validation and AFEC hinting logic for sub-1-TiB pool size failures.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/test_pool_commands.py Adds scenario coverage for pool creation without --size, and for --size-in-bytes (with AFEC hint expectation); includes a skipped 0.5 TiB scenario.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/test_volume_commands.py Adds an end-to-end CMK volume create scenario including private endpoint setup.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_pool_parameters.yaml Updates test recording to reflect new CLI version/requests.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_get_pool_by_name.yaml Updates test recording to reflect new CLI version/requests.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_string_size.yaml Updates test recording to reflect new CLI version/requests.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_size_in_bytes.yaml Adds recording for the new --size-in-bytes scenario.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_nosize.yaml Adds recording for the new “no size provided (default applied)” scenario.
src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_create.py Changes the default for --network-features to Standard.
src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_create.py Updates the account create CMK examples for bash/zsh and PowerShell quoting.
Comments suppressed due to low confidence (2)

src/azure-cli/azure/cli/command_modules/netappfiles/custom.py:311

  • The --size help text says the value must be an integer TiB “in multiples of 4”, but _resolve_pool_size_bytes validates “0.5 or any positive integer number of TiB” (and the PR description says integer multiples of 1 TiB). Please align the --size help text with the actual validation/behavior to avoid misleading users.
    args_schema.size_tib = AAZFloatArg(
        options=["--size"],
        arg_group="Properties",
        help="Provisioned size of the pool. Must be an integer number of tebibytes in multiples of 4. "
             "Use either --size or --size-in-bytes, not both.",
        nullable=on_update,
        fmt=AAZFloatArgFormat(minimum=0.5),
    )

src/azure-cli/azure/cli/command_modules/netappfiles/custom.py:318

  • The --size-in-bytes help text states values must be in 1 TiB chunks only, but _resolve_pool_size_bytes also allows 549755813888 bytes (512 GiB). Please update the help text to include the 512 GiB exception (or adjust validation if 512 GiB should not be accepted).
    args_schema.size_in_bytes = AAZIntArg(
        options=["--size-in-bytes"],
        arg_group="Properties",
        help="Provisioned size of the pool (in bytes). Allowed values are in 1TiB chunks (value must be multiple of 1099511627776). "
             "Use either --size or --size-in-bytes, not both.",
        nullable=on_update,
    )

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/azure-cli/azure/cli/command_modules/netappfiles/custom.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/netappfiles/custom.py Outdated
@yonzhan yonzhan assigned necusjz and unassigned kairu-ms May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants