Skip to content

[NetAppFiles] support 0.5 tib pool#33372

Open
audunn wants to merge 5 commits into
Azure:devfrom
audunn:release-Microsoft.NetApp-2026-03-01
Open

[NetAppFiles] support 0.5 tib pool#33372
audunn wants to merge 5 commits into
Azure:devfrom
audunn:release-Microsoft.NetApp-2026-03-01

Conversation

@audunn
Copy link
Copy Markdown
Member

@audunn audunn commented May 13, 2026

Related command
az netappfiles

Description
Updates az netappfiles to support smaller capacity pool sizes.

Testing Guide

History Notes

[NetAppFiles]: az netappfiles pool create: --size now accepts smaller size pools of value 0.5 to provision 512 GiB minimum pool size; otherwise it must be an integer multiple of 1 TiB.
[NetAppFiles]: az netappfiles pool update: --size now accepts smaller size pools of value 0.5 to provision 512 GiB minimum pool size; otherwise it must be an integer multiple of 1 TiB.
[NetAppFiles] az netappfiles pool create: Added new --size-in-bytes parameter accepting bytes directly (549755813888 for 512 GiB or any positive multiple of 1099511627776 for 1 TiB). --size and --size-in-bytes are mutually exclusive.
[NetAppFiles] az netappfiles pool update: Added new --size-in-bytes parameter accepting bytes directly (549755813888 for 512 GiB or any positive multiple of 1099511627776 for 1 TiB). --size and --size-in-bytes are mutually exclusive.


This checklist is used to make sure that common guidelines for a pull request are followed.

Copilot AI review requested due to automatic review settings May 13, 2026 15:00
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 13, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the az netappfiles pool create/update command surface to support the new 512 GiB (0.5 TiB) minimum capacity pool size, adds a --size-in-bytes option, and introduces tests/recordings to validate the new sizing rules and error behavior.

Changes:

  • Added pool-size parsing/validation to accept --size as TiB (float) down to 0.5, or --size-in-bytes as bytes; the two are mutually exclusive.
  • Augmented service errors for sub-1 TiB pool sizing to include an AFEC feature-registration hint, plus scenario tests and recordings for the new behaviors.
  • Updated generated AAZ files (notably volume create default and account create examples).

Reviewed changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/azure-cli/azure/cli/command_modules/netappfiles/custom.py Implements new --size/--size-in-bytes handling, validation, and AFEC hint augmentation for pool operations.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/test_pool_commands.py Adds scenario tests for 0.5 TiB sizing, byte sizing, invalid values, and mutual exclusivity.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_pool_parameters.yaml Updates recordings for existing pool parameter tests.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_get_pool_by_name.yaml Updates recordings for existing pool show-by-name/id tests.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_string_size.yaml Updates recordings for existing invalid string --size test.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_minimum_size.yaml Adds recording for --size 0.5 pool create behavior.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_size_in_bytes.yaml Adds recording for --size-in-bytes 549755813888 pool create behavior.
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_invalid_size.yaml Adds recording for rejecting invalid fractional TiB sizes (e.g., 1.5).
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_mutually_exclusive_size.yaml Adds recording for rejecting simultaneous --size and --size-in-bytes.
src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_create.py Changes the default for --network-features from Basic to Standard.
src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_create.py Updates command docstring examples for CMK + user-assigned identity usage across shells.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/azure-cli/azure/cli/command_modules/netappfiles/custom.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/netappfiles/custom.py Outdated
@yonzhan yonzhan assigned necusjz and unassigned kairu-ms May 13, 2026
@audunn
Copy link
Copy Markdown
Member Author

audunn commented May 15, 2026

lint fail does not seem to be on our module

ERROR: ************* Module azure.cli.command_modules.cosmosdb.custom
src/azure-cli/azure/cli/command_modules/cosmosdb/custom.py:2787:0: E0102: function already defined line 620 (function-redefined)
************* Module azure.cli.command_modules.appservice.custom
src/azure-cli/azure/cli/command_modules/appservice/custom.py:2431:0: E0102: function already defined line 64 (function-redefined)
************* Module azure.cli.command_modules.apim.custom
src/azure-cli/azure/cli/command_modules/apim/custom.py:583:12: E1206: Not enough arguments for logging format string (logging-too-few-args)
************* Module azure.cli.command_modules.botservice.custom
src/azure-cli/azure/cli/command_modules/botservice/custom.py:274:8: E1206: Not enough arguments for logging format string (logging-too-few-args)
************* Module azure.cli.command_modules.containerapp._utils
src/azure-cli/azure/cli/command_modules/containerapp/_utils.py:898:0: E0102: function already defined line 881 (function-redefined)
************* Module azure.cli.command_modules.synapse.manual.operations.sqlpoolblobauditingpolicy
src/azure-cli/azure/cli/command_modules/synapse/manual/operations/sqlpoolblobauditingpolicy.py:864:0: E0102: function already defined line 463 (function-redefined)
src/azure-cli/azure/cli/command_modules/synapse/manual/operations/sqlpoolblobauditingpolicy.py:882:0: E0102: function already defined line 447 (function-redefined)
************* Module azure.cli.command_modules.batch._command_type
src/azure-cli/azure/cli/command_modules/batch/_command_type.py:762:52: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants