[Core] git diff updated to match the two commits (branches head) only — no merge base needed#9889
[Core] git diff updated to match the two commits (branches head) only — no merge base needed#9889msarfraz wants to merge 1 commit into
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @msarfraz, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Pull request overview
Updates the CI helper that scans diffs for forbidden raw GitHub URLs so it can diff two specific refs directly, avoiding reliance on a merge-base (which can be unavailable in shallow fetch scenarios).
Changes:
- Switch
git diffinvocation fromtgt...src(merge-base diff) totgt..src(direct ref-to-ref diff).
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Description
when comparing PR changes to find external URLs, git diff command updated to match the two commits (branches head) only — no merge base needed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.