Skip to content

[Core] git diff updated to match the two commits (branches head) only — no merge base needed#9889

Open
msarfraz wants to merge 1 commit into
Azure:mainfrom
msarfraz:network-isolation-fix
Open

[Core] git diff updated to match the two commits (branches head) only — no merge base needed#9889
msarfraz wants to merge 1 commit into
Azure:mainfrom
msarfraz:network-isolation-fix

Conversation

@msarfraz
Copy link
Copy Markdown
Contributor

@msarfraz msarfraz commented May 20, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Description
when comparing PR changes to find external URLs, git diff command updated to match the two commits (branches head) only — no merge base needed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 20, 2026 01:05
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented May 20, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @msarfraz,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 20, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI helper that scans diffs for forbidden raw GitHub URLs so it can diff two specific refs directly, avoiding reliance on a merge-base (which can be unavailable in shallow fetch scenarios).

Changes:

  • Switch git diff invocation from tgt...src (merge-base diff) to tgt..src (direct ref-to-ref diff).

@msarfraz msarfraz self-assigned this May 20, 2026
@msarfraz msarfraz changed the title [Core] git diff updated to match the two commits — no merge base needed. [Core] git diff updated to match the two commits (branches head) only — no merge base needed May 20, 2026
@msarfraz msarfraz requested a review from Copilot May 20, 2026 05:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@yonzhan yonzhan requested a review from wangzelin007 May 20, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants