-
Notifications
You must be signed in to change notification settings - Fork 27
Open
Labels
Description
Now that the issues around EXISTS were fixed in SPARQL 1.2 (w3c/sparql-query#302), we should make sure we have good tests to capture this.
Luckily, @afs collected many tests already in https://github.com/afs/SPARQL-exists
So I would propose incorporating those tests into this repo.
@afs do you agree?
If so, do you want to make a PR?
I can also do it if this is lower on your priority list.
I manually went through the tests to validate them based on my understanding of what the spec says now.
This is my analysis:
- exists-1-empty-bgp: ok
- exists-2-def-var: Do we really want these to be negative syntax tests, or just evaluation errors? A negative syntax tests may require a lot of effort on the parser's side.
- exists-3-bgp: I think both of the tests there should produce a valid solution mapping (instead of only the second test).
- exists-4-minus: ok
- exists-5-scope/exists-subselect-projection: Should be valid I think
- exists-6-places: ok
- exists-bnodes: ok
- exists-filter/scope-filter-01: I would expect a single result here (as this follows the without-projection approach; values projected out in sub-SELECTs are affected)
- other: Not checked yet
Reactions are currently unavailable