Skip to content

Switch to or add DOM\Document support #37

@bitwise-operators

Description

@bitwise-operators

The current version of the engine can accept html input as a DomDocument object using the fromDomDocument() method.

However, PHP 8.4 saw a modern replacement for that class in the form of Dom\Document and related classes. (https://www.php.net/manual/en/class.dom-document.php)

Since the API for version 5 hasn't been finalized yet, would this be the right moment to switch over to that new and improved version?

Supporting both might be an option too as I think the interfaces are mostly compatible, at least for the parts relevant to Templado, but I would think that checking compatibility is harder than a hard switch with version 5, although this would raise the minimum PHP version to 8.4

I wouldn't mind putting some code in and setting up a pull request, but I figured it is probably best to figure out the desired option first.

(My preference would be to switch over. There's a reason the old one is being replaced...)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions