fix(pulsar): validate WebServiceURL in config

Author: freeznet

pkg/mcp/builders/pulsar/status.go

@@ -95,10 +95,6 @@ func (b *PulsarAdminStatusToolBuilder) buildStatusHandler() func(context.Context
 			return b.handleError("get Pulsar configuration", err), nil
 		}
 
-		if cfg.WebServiceURL == "" {
-			cfg.WebServiceURL = admin.DefaultWebServiceURL
-		}
-
 		authProvider, err := pulsaradminauth.GetAuthProvider((*pulsaradminconfig.Config)(cfg))
 		if err != nil {
 			return b.handleError("build status auth provider", err), nil

pkg/mcp/builders/pulsar/status_test.go

@@ -19,7 +19,10 @@ import (
 	"testing"
 
 	"github.com/mark3labs/mcp-go/mcp"
+	"github.com/streamnative/pulsarctl/pkg/cmdutils"
 	"github.com/streamnative/streamnative-mcp-server/pkg/mcp/builders"
+	mcpCtx "github.com/streamnative/streamnative-mcp-server/pkg/mcp/internal/context"
+	pulsarsession "github.com/streamnative/streamnative-mcp-server/pkg/pulsar"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
@@ -56,4 +59,26 @@ func TestPulsarAdminStatusToolBuilder(t *testing.T) {
 		require.NotNil(t, result)
 		assert.True(t, result.IsError)
 	})
+
+	t.Run("Handler_EmptyWebServiceURL", func(t *testing.T) {
+		tools, err := builder.BuildTools(context.Background(), builders.ToolBuildConfig{
+			Features: []string{"pulsar-admin-brokers-status"},
+		})
+		require.NoError(t, err)
+		require.Len(t, tools, 1)
+
+		ctx := mcpCtx.WithPulsarSession(context.Background(), &pulsarsession.Session{
+			PulsarCtlConfig: &cmdutils.ClusterConfig{},
+		})
+
+		result, callErr := tools[0].Handler(ctx, mcp.CallToolRequest{})
+		require.NoError(t, callErr)
+		require.NotNil(t, result)
+		assert.True(t, result.IsError)
+		require.Len(t, result.Content, 1)
+
+		text, ok := result.Content[0].(mcp.TextContent)
+		require.True(t, ok)
+		assert.Contains(t, text.Text, "Please set the cluster context first")
+	})
 }

pkg/pulsar/connection.go

@@ -191,7 +191,7 @@ func (s *Session) GetPulsarCtlConfig() (*cmdutils.ClusterConfig, error) {
 	s.mutex.RLock()
 	defer s.mutex.RUnlock()
 
-	if s.PulsarCtlConfig == nil {
+	if s.PulsarCtlConfig == nil || s.PulsarCtlConfig.WebServiceURL == "" {
 		return nil, fmt.Errorf("err: ContextNotSetErr: Please set the cluster context first")
 	}
 

pkg/pulsar/connection_test.go

@@ -0,0 +1,50 @@
+// Copyright 2025 StreamNative
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package pulsar
+
+import (
+	"testing"
+
+	"github.com/streamnative/pulsarctl/pkg/cmdutils"
+	"github.com/stretchr/testify/require"
+)
+
+func TestSessionGetPulsarCtlConfigRequiresWebServiceURL(t *testing.T) {
+	session := &Session{}
+
+	_, err := session.GetPulsarCtlConfig()
+	require.EqualError(t, err, "err: ContextNotSetErr: Please set the cluster context first")
+
+	session.PulsarCtlConfig = &cmdutils.ClusterConfig{}
+
+	_, err = session.GetPulsarCtlConfig()
+	require.EqualError(t, err, "err: ContextNotSetErr: Please set the cluster context first")
+}
+
+func TestSessionGetPulsarCtlConfigReturnsCopy(t *testing.T) {
+	session := &Session{
+		PulsarCtlConfig: &cmdutils.ClusterConfig{
+			WebServiceURL: "http://pulsar.example.com:8080",
+		},
+	}
+
+	cfg, err := session.GetPulsarCtlConfig()
+	require.NoError(t, err)
+	require.Equal(t, "http://pulsar.example.com:8080", cfg.WebServiceURL)
+
+	cfg.WebServiceURL = "http://mutated.example.com:8080"
+
+	require.Equal(t, "http://pulsar.example.com:8080", session.PulsarCtlConfig.WebServiceURL)
+}