Add db.setWalHook()#16
Open
jamiebuilds-signal wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to call
sqlite3_wal_hook()to setup a JS callback.Importantly, setting your own WAL hook replaces/disables
sqlite3_wal_autocheckpoint:If the JS callback throws, the
WalHookWrap::Callfunction will swallow the exception and returnSQLITE_OK. The alternative is that that the statement that triggered the commit would throw.The implementation is basically the same as
db.createFunction()but it differs in how it gets cleaned up since we don't have thexFinalparam to call the destructor atFunctionWrap::Final. Instead its stored atDatabase::wal_hook_wrap_which then needs to be cleaned up on database close.