refactor: make publish wait generic for dev and release

- Add status_context input to e2e workflow for flexibility
- Add commit status reporting to publish-release job
- Update on-main-push.yml to pass SHA and wait for npm-publish-release
- Both dev and release e2e tests now wait for their respective publish

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: scolladon

.github/workflows/npm-publisher.yml

@@ -42,6 +42,18 @@ jobs:
     if: github.event_name == 'repository_dispatch' && github.event.action == 'npm-publish-release'
     runs-on: ubuntu-latest
     steps:
+      - name: Set pending commit status
+        if: ${{ github.event.client_payload.ref != '' }}
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SHA: ${{ github.event.client_payload.ref }}
+        run: |
+          gh api repos/${{ github.repository }}/statuses/$SHA \
+            -f state=pending \
+            -f context=npm-publish-release \
+            -f description="Publishing release to npm..." \
+            -f target_url="${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
+
       - name: Checkout sources
         uses: actions/checkout@v6
 
@@ -62,6 +74,30 @@ jobs:
           NPM_TAG: ${{ github.event.client_payload.tag || 'latest-rc' }}
         run: npm publish --provenance --access public --tag "$NPM_TAG"
 
+      - name: Set success commit status
+        if: ${{ success() && github.event.client_payload.ref != '' }}
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SHA: ${{ github.event.client_payload.ref }}
+        run: |
+          gh api repos/${{ github.repository }}/statuses/$SHA \
+            -f state=success \
+            -f context=npm-publish-release \
+            -f description="Release published to npm" \
+            -f target_url="${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
+
+      - name: Set failure commit status
+        if: ${{ failure() && github.event.client_payload.ref != '' }}
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SHA: ${{ github.event.client_payload.ref }}
+        run: |
+          gh api repos/${{ github.repository }}/statuses/$SHA \
+            -f state=failure \
+            -f context=npm-publish-release \
+            -f description="Failed to publish release" \
+            -f target_url="${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
+
   publish-dev:
     if: github.event_name == 'repository_dispatch' && github.event.action == 'npm-publish-dev'
     runs-on: ubuntu-latest

.github/workflows/on-main-push.yml

@@ -41,11 +41,13 @@ jobs:
         with:
           token: ${{ secrets.RELEASE_PAT }}
           event-type: npm-publish-release
-          client-payload: '{"tag": "latest-rc"}'
+          client-payload: '{"tag": "latest-rc", "ref": "${{ github.sha }}"}'
 
   test-release:
     uses: ./.github/workflows/run-e2e-tests.yml
     needs: [prepare-release, release]
     with:
       channel: ${{ needs.prepare-release.outputs.version }}
+      commit_sha: ${{ github.sha }}
+      status_context: npm-publish-release
     secrets: inherit

.github/workflows/on-pull-request.yml

@@ -145,4 +145,5 @@ jobs:
     with:
       channel: ${{ needs.publish-dev.outputs.devChannel }}
       commit_sha: ${{ github.event.pull_request.head.sha }}
+      status_context: npm-publish-dev
     secrets: inherit

.github/workflows/run-e2e-tests.yml

@@ -8,7 +8,11 @@ on:
         default: latest-rc
       commit_sha:
         type: string
-        description: "Commit SHA to wait for publish status (optional)"
+        description: "Commit SHA to wait for publish status"
+        required: false
+      status_context:
+        type: string
+        description: "Commit status context to wait for (e.g., npm-publish-dev, npm-publish-release)"
         required: false
 
 jobs:
@@ -42,15 +46,16 @@ jobs:
         run: npm install -g @salesforce/cli
 
       - name: Wait for npm publish to complete
-        if: ${{ inputs.commit_sha != '' }}
+        if: ${{ inputs.commit_sha != '' && inputs.status_context != '' }}
         shell: bash
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           COMMIT_SHA: ${{ inputs.commit_sha }}
+          STATUS_CONTEXT: ${{ inputs.status_context }}
         run: |
-          echo "Waiting for npm-publish-dev status on $COMMIT_SHA (timeout: 30s)..."
+          echo "Waiting for $STATUS_CONTEXT status on $COMMIT_SHA (timeout: 30s)..."
           for i in $(seq 1 6); do
-            STATUS=$(gh api repos/${{ github.repository }}/commits/$COMMIT_SHA/status --jq '.statuses[] | select(.context == "npm-publish-dev") | .state' 2>/dev/null || echo "")
+            STATUS=$(gh api "repos/${{ github.repository }}/commits/$COMMIT_SHA/status" --jq ".statuses[] | select(.context == \"$STATUS_CONTEXT\") | .state" 2>/dev/null || echo "")
             echo "Attempt $i/6 - Status: ${STATUS:-not found}"
             if [ "$STATUS" = "success" ]; then
               echo "Publish succeeded!"
@@ -61,7 +66,7 @@ jobs:
             fi
             sleep 5
           done
-          echo "Timeout waiting for npm-publish-dev status"
+          echo "Timeout waiting for $STATUS_CONTEXT status"
           exit 1
 
       - name: Install new plugin version