Errors with Maven wrapper after upgrading to Renovate 43.70.0

[dpiva97]

How are you running Renovate?

Self Hosted Gitlab with renovate runner version 26.0.0

Which platform you running Renovate on?

GitLab (.com or self-hosted)

Which version of Renovate are you using?

43.70.0

Please tell us more about your question or problem

We have started encountering errors from version 43.70.0 when Renovate tries to update the Maven wrapper. The errors appear to be permission-related (EACCES) when spawning ./mvnw.
Could you please advise if this is a known issue or if there’s a workaround?

Logs (if relevant)

Logs

ERROR: Error executing maven wrapper update command. (repository=****, baseBranch=develop, branch=renovate/all-minor-patch)
    "err": {
        "cmd": "./mvnw wrapper:wrapper -Dtype=script",
        "stderr": "",
        "stdout": "",
        "options": {
        "cwd": "/builds/****",
        "env": [
            "CI",
            "HOME",
            "PATH",
            "LC_ALL",
            "LANG",
            "DOCKER_HOST",
            "CONTAINERBASE_CACHE_DIR"
        ],
        "maxBuffer": 10485760,
        "timeout": 900000,
        "stdin": "pipe",
        "stdout": "pipe",
        "stderr": "pipe"
        },
        "err": {
        "errno": -13,
        "code": "EACCES",
        "syscall": "spawn ./mvnw",
        "path": "./mvnw",
        "spawnargs": ["wrapper:wrapper", "-Dtype=script"],
        "message": "spawn ./mvnw EACCES",
        "stack": "Error: spawn ./mvnw EACCES\n    at Process.ChildProcess._handle.onexit (node:internal/child_process:286:19)\n    at onErrorNT (node:internal/child_process:484:16)\n    at processTicksAndRejections (node:internal/process/task_queues:90:21)"
        },
        "name": "ExecError",
        "message": "spawn ./mvnw EACCES",
        "stack": "ExecError: spawn ./mvnw EACCES\n    at ChildProcess.<anonymous> (file:///usr/local/renovate/lib/util/exec/common.ts:146:14)\n    at ChildProcess.emit (node:events:520:35)\n    at ChildProcess.emit (node:domain:489:12)\n    at Process.ChildProcess._handle.onexit (node:internal/child_process:292:12)\n    at onErrorNT (node:internal/child_process:484:16)\n    at processTicksAndRejections (node:internal/process/task_queues:90:21)"
    }
ERROR: unhandledRejection (repository=****, baseBranch=develop, branch=renovate/all-minor-patch)
    "err": {
        "errno": -13,
        "code": "EACCES",
        "syscall": "spawn ./mvnw",
        "path": "./mvnw",
        "spawnargs": ["wrapper:wrapper", "-Dtype=script"],
        "message": "spawn ./mvnw EACCES",
        "stack": "Error: spawn ./mvnw EACCES\n    at Process.ChildProcess._handle.onexit (node:internal/child_process:286:19)\n    at onErrorNT (node:internal/child_process:484:16)\n    at processTicksAndRejections (node:internal/process/task_queues:90:21)"
    }

[jamietanna]

To confirm, what version of Renovate were you using before? It'd be useful to have a way of determining the gap between updates to try and narrow down where this may have broken

[dpiva97]

I’m using version 26 of the Renovate GitLab runner, which relies on a Docker image with the latest 43.x version.
I pinned the version starting from the last known working one (43.64.3) and incremented it step by step. It’s clear that the issue was introduced in version 43.70.0.
Looking at the release notes, you can see that some changes were made to the Maven wrapper.

[jamietanna]

Is there definitely a ./mvnw in the repo? Is it executable?

[dpiva97]

Yes, the file is present and executable. In any case, it works without errors up to version 43.70.0

[github-actions[bot]]

Hi there,

Please help this Discussion progress by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the reproduction in your own repository. Ensure it's actually minimal (no unnecesary dependencies or config), or it will be rejected by maintainers.
5. Install the Renovate app to verify that what you say happens (or doesn't happen) reproduces.
6. Fill out the information in your repository's README.md. What you describe there should reflect what you see in this repo, with the hosted app, and not what you saw in your original repo/environment.
7. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.
8. Add a Discussion comment mentioning that the reproduction repo is now available and linked.

If you need help with running Renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[dpiva97]

I’ve finally reproduced the error. Check the latest commits and PRs.

[jamietanna]

Stepping through the debug logs I see:

DEBUG: Deleted old maven-wrapper.jar (branch="renovate/maven-updates")
{
  "baseBranch": "main",
  "jarPath": "mvnw"
}

That doesn't seem right - that's not a JAR 🤔

[dpiva97]

After reading the renovate-log.ndjson logs more carefully, it appears that the update is executed 3 times once for each file (mvnw, mvnw.cmd, maven-wrapper.properties). The first run completes successfully, the second one fails with a missing execution permissions error, and the third one seems to detect the missing permissions and adds them.
I'm not sure whether it's expected behavior for the update to run 3 times, but if it is, it seems like the permissions are not being handled correctly across the 3 executions.

[jamietanna]

Looks like a comment of mine didn't send - should be fixed as of #42141