PR'S created without dashboard approval

[thompson-tomo]

updates.json

How are you running Renovate?

A Mend.io-hosted app

Which platform you running Renovate on?

GitHub.com

Which version of Renovate are you using?

No response

Please tell us more about your question or problem

I have the following configuration:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": [
    "config:best-practices",
    "helpers:pinGitHubActionDigestsToSemver",
    ":separateMultipleMajorReleases"
  ],
  "packageRules": [
    {
      "groupName": "all patch versions",
      "matchUpdateTypes": ["patch"],
      "schedule": ["before 8am every weekday"]
    },
    {
      "matchUpdateTypes": ["minor", "major"],
      "schedule": ["before 8am on Monday"]
    },
    {
      "matchUpdateTypes": ["major"],
      "matchManagers": ["ruby"],
      "dependencyDashboardApproval": true
    }
  ],
  "labels": [
    "dependencies"
  ]
}

The expectation is that due to the dependencyDashboardApproval setting, pr's wouldn't be auto created for major ruby updates due to them needing dashboard approval however they were created based on the schedule.

Expectation is that the schedule would've been ovrr-written due to the approval and https://docs.mend.io/wsk/renovate-package-rules-guide mentioning

are processed in order, with later rules potentially overriding earlier ones

Logs (if relevant)

See attachment

Replace this text with your logs, between the starting and ending triple backticks

[github-actions[bot]]

Hi there,

This issue or discussion is missing some logs, making it difficult or impossible to help you. Depending on which situation applies follow one, some or all of these instructions.

No logs at all

If you haven't posted any log yet, we need you to find and copy/paste the log into the issue template.

Finding logs on hosted app

Select me to read instructions

If you use the Mend Renovate app (GitHub):

1. Log in to the Mend Developer Portal
2. Navigate to the correct organization and repository
3. Locate the appropriate log (it may not always be the latest one)
4. Copy/paste the log contents
5. Follow the steps in the formatting your logs section

Finding logs when self-hosting

Select me to read instructions

Read the Renovate docs, troubleshooting, self-hosted to learn how to find the logs.

Formatting your logs

Select me to read instructions

Please put your logs in a <details> and <summary> element like this:

<details><summary>Select me to see logs</summary>

```
Copy/paste your logs here, between the starting and ending backticks
```

</details>

If you feel the logs are too large to paste here, please use a service like GitHub Gist and paste the link here.

Good luck,

The Renovate team

[thompson-tomo]

Have attached debug logs from a local run.
In effect, pr's for activerecord, minitest etc have all been created in the repo and a large number awaiting are awaiting the update schedule see open-telemetry/opentelemetry-ruby-contrib#1803.

What would be helpful is if the update objects in the debug logs also contained the require approval flag.

Note, i am just a contributor to that repo hence i don't have admin rights.

[thompson-tomo]

@jamietanna any update on this?

[thompson-tomo]

@jamietanna i have been trying to resolve this issue but it is still proposing major dependency updates without approvals open-telemetry/opentelemetry-ruby-contrib#1803. The updated config is https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/main/.github/renovate.json5

[jamietanna]

Hey @thompson-tomo - taking a look at this again now

The current usage of matchCategories will mean you're not getting major versions for (via) bundler, puppet, ruby-version which is I think expected.

Taking a look at how your repo is set up, and what Renovate's finding when it raises open-telemetry/opentelemetry-ruby-contrib#1933, I'm pretty confident that:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "packageRules": [
    // other rules
    {
      "description": "...",
      "matchDepNames": [
        "ruby"
      ],
      "matchUpdateTypes": [
        "major"
      ],
      "dependencyDashboardApproval": true
    }
  ]
}

Should do it

I know this was close to one of the previous attempts, but that should do it now 🤞

[jamietanna]

Glad that worked, now!