Merge pull request #821 from AKuHAK/renamefix

uyjulian · web-flow · commit 023b678f3548 · 2026-03-15T08:13:16.000-05:00
Fix apaRename function to properly clear and copy newId to header
diff --git a/iop/hdd/apa/src/hdd_fio.c b/iop/hdd/apa/src/hdd_fio.c
@@ -559,7 +559,8 @@ static int apaRename(s32 device, const char *oldId, const char *newId)
     }
 
     // do the renaming :) note: subs have no names!!
-    memcpy(clink->header->id, newId, APA_IDMAX);
+    memset(clink->header->id, 0, APA_IDMAX);
+    strncpy(clink->header->id, newId, APA_IDMAX - 1);
 
     // touch creation time
     apaGetTime(&clink->header->created);

Original file line number	Diff line number	Diff line change
`@@ -559,7 +559,8 @@ static int apaRename(s32 device, const char oldId, const char newId)`
`559`	`559`	`}`
`560`	`560`
`561`	`561`	`// do the renaming :) note: subs have no names!!`
`562`		`- memcpy(clink->header->id, newId, APA_IDMAX);`
	`562`	`+ memset(clink->header->id, 0, APA_IDMAX);`
	`563`	`+ strncpy(clink->header->id, newId, APA_IDMAX - 1);`
`563`	`564`
`564`	`565`	`// touch creation time`
`565`	`566`	`apaGetTime(&clink->header->created);`