BUG: Cannot applt post render patch for PVCs

[Frusoz]

Problem Description

I'm trying to apply this patch to multiple PVCs but the add-on controller throws some errors and the label is not applied.

patches:
  - target:
      group: ""
      version: v1
      kind: PersistentVolumeClaim
      name: "data-thanos-.*"
    patch: |
      - op: add
        path: /metadata/labels/velero.io~1exclude-from-backup
        value: "true"

or

patches:
    - target:
        group: ""
        version: v1
        kind: PersistentVolumeClaim
        name: "data-thanos-.*"
      patch: |
        apiVersion: v1
        kind: PersistentVolumeClaim
        metadata:
          labels:
            velero.io/exclude-from-backup: "true"

System Information

CLUSTERAPI VERSION: operator, 0.26.0
SVELTOS VERSION: v1.8.0
KUBERNETES VERSION: v1.36.0

Logs

I0508 08:41:02.440115       1 handlers_helm.go:1944] "failed to upgrade: error while running post render on files: trouble configuring builtin PatchTransformer with config: \npatch: |\n  apiVersion: v1\n  kind: PersistentVolumeClaim\n  metadata:\n    labels:\n      [velero.io/exclude-from-backup](http://velero.io/exclude-from-backup): \"true\"\ntarget:\n  kind: PersistentVolumeClaim\n  name: data-thanos-.*\n  version: v1\n: unable to parse SM or JSON patch from [patch: "apiVersion: v1\nkind: PersistentVolumeClaim\nmetadata:\n  labels:\n    velero.io/exclude-from-backup: \"true\""]"

[gianlucam76]

@Frusoz can you please add the profile leading to this? thank you

[Frusoz]

@Frusoz can you please add the profile leading to this? thank you

apiVersion: config.projectsveltos.io/v1beta1
kind: ClusterProfile
metadata:
  name: platform-mgmt
  namespace: projectsveltos
spec:
  clusterSelector:
    matchLabels:
      environment: mgmt
  syncMode: ContinuousWithDriftDetection
  reloader: false
  stopMatchingBehavior: LeavePolicies
  dependsOn:
    - core-mgmt

  templateResourceRefs:
    - resource:
        apiVersion: v1
        kind: Secret
        name: hetzner-credentials
        namespace: velero
      identifier: HetznerCredentialsExternalSecret

  helmCharts:
    - repositoryURL: https://piraeus.io/helm-charts/
      repositoryName: piraeus-charts
      chartName: piraeus-charts/snapshot-controller
      chartVersion: 5.0.3
      releaseName: snapshot-controller
      releaseNamespace: kube-system
      helmChartAction: Install
      values: |
        webhook:
          enabled: false

    - repositoryURL: https://vmware-tanzu.github.io/helm-charts
      repositoryName: vmware-tanzu
      chartName: vmware-tanzu/velero
      chartVersion: 12.0.0
      releaseName: velero
      releaseNamespace: velero
      helmChartAction: Install
      valuesFrom:
        - kind: ConfigMap
          name: velero-values-base
          namespace: projectsveltos
      values: |
        schedules:
          daily-pv-backup:
            disabled: false
            labels:
              environment: {{ index .Cluster.metadata.labels "environment" }}
              backup-type: daily-full
            schedule: "0 5 * * *"
            template:
              includeClusterResources: true
              includedResources:
                - persistentvolumes
                - persistentvolumeclaims
              labelSelector:
                matchLabels:
                  backup: "true"
              snapshotVolumes: true
              storageLocation: hetzner-bucket-bsl
              ttl: 168h

    - repositoryURL: https://helm-charts.sinextra.dev
      repositoryName: sinextra
      chartName: sinextra/talos-backup
      chartVersion: 0.1.2
      releaseName: talos-backup
      releaseNamespace: default
      helmChartAction: Install
      values: |
        schedule: "0 */12 * * *"
        env:
          - name: AWS_REGION
            value: "fsn1"
          - name: BUCKET
            value: "{{ .Cluster.metadata.name }}-backup"
          - name: CLUSTER_NAME
            value: "{{ .Cluster.metadata.name }}"
          - name: S3_PREFIX
            value: "etcd"
          - name: AGE_X25519_PUBLIC_KEY
            value: ""
          - name: USE_PATH_STYLE
            value: "true"
        envSecretName: "hetzner-credentials"

    - repositoryURL: https://kubernetes-sigs.github.io/metrics-server/
      repositoryName: metrics-server
      chartName: metrics-server/metrics-server
      chartVersion: "3.13.0"
      releaseName: metrics-server
      releaseNamespace: kube-system
      helmChartAction: Install
      values: |
        args:
          - --kubelet-insecure-tls
        resources:
          requests:
            cpu: 100m
            memory: 200Mi
          limits:
            cpu: 500m
            memory: 500Mi
        tolerations:
          - key: node-role.kubernetes.io/control-plane
            operator: Exists
            effect: NoSchedule
        replicas: 2
        podDisruptionBudget:
          enabled: true
          minAvailable: 1
        updateStrategy:
          type: RollingUpdate
          rollingUpdate:
            maxUnavailable: 1
        serviceMonitor:
          enabled: false

    - repositoryURL: https://prometheus-community.github.io/helm-charts
      repositoryName: prometheus-community
      chartName: prometheus-community/kube-prometheus-stack
      chartVersion: "84.3.0"
      releaseName: kube-prometheus-stack
      releaseNamespace: monitoring
      helmChartAction: Install
      valuesFrom:
        - kind: ConfigMap
          name: prometheus-values-base
          namespace: projectsveltos

    - repositoryURL: https://thanos-community.github.io/helm-charts
      repositoryName: thanos-community
      chartName: thanos-community/thanos
      chartVersion: "0.10.0"
      releaseName: thanos
      releaseNamespace: monitoring
      helmChartAction: Install
      valuesFrom:
        - kind: ConfigMap
          name: thanos-values-base
          namespace: projectsveltos

    - repositoryURL: https://grafana.github.io/helm-charts
      repositoryName: grafana
      chartName: grafana/loki
      chartVersion: 7.0.0
      releaseName: loki
      releaseNamespace: monitoring
      helmChartAction: Install
      valuesFrom:
        - kind: ConfigMap
          name: loki-values-base
          namespace: projectsveltos

    - repositoryURL: https://grafana.github.io/helm-charts
      repositoryName: grafana
      chartName: grafana/alloy
      chartVersion: 1.8.1
      releaseName: alloy
      releaseNamespace: monitoring
      helmChartAction: Install
      valuesFrom:
        - kind: ConfigMap
          name: alloy-values-base
          namespace: projectsveltos

    - repositoryURL: https://kubernetes-sigs.github.io/headlamp/
      repositoryName: headlamp
      chartName: headlamp/headlamp
      chartVersion: 0.41.0
      releaseName: headlamp
      releaseNamespace: headlamp
      helmChartAction: Install
      valuesFrom:
        - kind: ConfigMap
          name: headlamp-values-base
          namespace: projectsveltos

  kustomizationRefs:
    - kind: GitRepository
      name: sveltos-gitops
      namespace: flux-system
      path: "sveltos-manifests/cluster-profiles-addons/{{ index
        .Cluster.metadata.labels \"environment\" }}/platform"