#1789 misc: add remembered file manager open prompts

Author: pbek

CHANGELOG.md

@@ -1,5 +1,12 @@
 # QOwnNotes Changelog
 
+## 26.4.15
+
+- Added a rememberable confirmation dialog before opening items in the file
+  manager from note reveal and export actions, so accidental folder windows can
+  be suppressed per action after choosing **No** once with **Don't ask again!**
+  (for [#1789](https://github.com/pbek/QOwnNotes/issues/1789))
+
 ## 26.4.14
 
 - Allow dragging a Markdown or text note file into the **note editor**, so it is

src/dialogs/storedattachmentsdialog.cpp

@@ -301,7 +301,8 @@ void StoredAttachmentsDialog::on_openFolderButton_clicked() {
     }
 
     QString filePath = getFilePath(item);
-    Utils::Misc::openFolderSelect(filePath);
+    Utils::Misc::openFolderSelect(filePath,
+                                  QStringLiteral("show-stored-attachment-in-file-manager"));
 }
 
 void StoredAttachmentsDialog::on_fileTreeWidget_customContextMenuRequested(const QPoint &pos) {

src/dialogs/storedimagesdialog.cpp

@@ -499,7 +499,7 @@ void StoredImagesDialog::on_openFolderButton_clicked() {
     }
 
     QString filePath = getFilePath(item);
-    Utils::Misc::openFolderSelect(filePath);
+    Utils::Misc::openFolderSelect(filePath, QStringLiteral("show-stored-image-in-file-manager"));
 }
 
 void StoredImagesDialog::on_orphanedCheckBox_toggled(bool checked) {

src/entities/note.cpp

@@ -969,7 +969,8 @@ bool Note::exportToPath(const QString &destinationPath, bool withAttachedFiles)
 
     file.flush();
     file.close();
-    Utils::Misc::openFolderSelect(destinationPath);
+    Utils::Misc::openFolderSelect(destinationPath,
+                                  QStringLiteral("show-exported-note-in-file-manager"));
 
     return true;
 }

src/mainwindow.cpp

@@ -5469,7 +5469,8 @@ void MainWindow::pasteMediaIntoNote() {
 }
 
 void MainWindow::on_actionShow_note_in_file_manager_triggered() {
-    Utils::Misc::openFolderSelect(currentNote.fullNoteFilePath());
+    Utils::Misc::openFolderSelect(currentNote.fullNoteFilePath(),
+                                  QStringLiteral("show-note-in-file-manager"));
 }
 
 /**

src/managers/exportprintmanager.cpp

@@ -195,7 +195,8 @@ void ExportPrintManager::exportNoteAsPDF(QTextDocument *doc) {
 
     if (prepareExportNoteAsPDFPrinter(printer)) {
         doc->print(printer);
-        Utils::Misc::openFolderSelect(printer->outputFileName());
+        Utils::Misc::openFolderSelect(printer->outputFileName(),
+                                      QStringLiteral("show-exported-pdf-in-file-manager"));
     }
 
     delete printer;
@@ -283,7 +284,8 @@ void ExportPrintManager::on_actionExport_preview_HTML_triggered() {
                 NoteFolder::currentLocalPath(), _mainWindow->getMaxImageWidth(), true, true, true);
             file.flush();
             file.close();
-            Utils::Misc::openFolderSelect(fileName);
+            Utils::Misc::openFolderSelect(
+                fileName, QStringLiteral("show-exported-note-html-in-file-manager"));
         }
     }
 }

src/utils/misc.cpp

@@ -54,6 +54,7 @@
 #include <QtGui/QIcon>
 #include <utility>
 
+#include "gui.h"
 #include "services/settingsservice.h"
 #if (QT_VERSION < QT_VERSION_CHECK(5, 6, 0))
 #include <QHostInfo>
@@ -110,7 +111,19 @@ void Utils::Misc::openPath(const QString &absolutePath) {
  * (if possible) the item at the given path
  * (thank you to qBittorrent for the inspiration)
  */
-void Utils::Misc::openFolderSelect(const QString &absolutePath) {
+void Utils::Misc::openFolderSelect(const QString &absolutePath,
+                                   const QString &questionDialogIdentifier) {
+    if (!questionDialogIdentifier.isEmpty() &&
+        Utils::Gui::questionNoSkipOverride(
+            QApplication::activeWindow(),
+            QCoreApplication::translate("Utils::Misc", "Open folder in file manager"),
+            QCoreApplication::translate("Utils::Misc",
+                                        "Do you want to show this item in your file manager?"),
+            questionDialogIdentifier, QMessageBox::Yes | QMessageBox::No,
+            QMessageBox::Yes) != QMessageBox::Yes) {
+        return;
+    }
+
     const QString path = QDir::fromNativeSeparators(absolutePath);
 #ifdef Q_OS_WIN
     if (QFileInfo(path).exists()) {

src/utils/misc.h

@@ -62,7 +62,8 @@ struct SearchEngine {
 };
 
 void openPath(const QString &absolutePath);
-void openFolderSelect(const QString &absolutePath);
+void openFolderSelect(const QString &absolutePath,
+                      const QString &questionDialogIdentifier = QString());
 QString removeIfStartsWith(QString text, const QString &removeString);
 QString removeIfEndsWith(QString text, const QString &removeString);
 QString prependIfDoesNotStartWith(QString text, const QString &startString);

src/widgets/fontcolorwidget.cpp

@@ -790,7 +790,8 @@ void FontColorWidget::on_exportSchemeButton_clicked() {
                 exportSettings.setValue(key, value);
             }
 
-            Utils::Misc::openFolderSelect(fileName);
+            Utils::Misc::openFolderSelect(
+                fileName, QStringLiteral("show-exported-color-schema-in-file-manager"));
         }
     }
 }

src/widgets/htmlpreviewwidget.cpp

@@ -198,7 +198,8 @@ void HtmlPreviewWidgetInternal::exportAsHTMLFile() {
             out << html();
             file.flush();
             file.close();
-            Utils::Misc::openFolderSelect(fileName);
+            Utils::Misc::openFolderSelect(
+                fileName, QStringLiteral("show-exported-preview-html-in-file-manager"));
         }
     }
 }