Skip to content

Commit 8dbb25c

Browse files
mpywclaude
andcommitted
fix: handle Close() error returns in tests
Wrap defer Close() calls with anonymous functions to explicitly ignore the error return value, satisfying errcheck linter. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 8544e5b commit 8dbb25c

4 files changed

Lines changed: 13 additions & 10 deletions

File tree

e2e/database_init_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func TestDatabaseInit_InlineSQL(t *testing.T) {
2424
conn, err := db.Connect(cfg, configDir)
2525
require.NoError(t, err)
2626
require.NotNil(t, conn)
27-
defer conn.Close()
27+
defer func() { _ = conn.Close() }()
2828

2929
// Create server handler
3030
mux, err := server.NewServeMux(conn, cfg, configDir)
@@ -91,7 +91,7 @@ queries:
9191
conn, err := db.Connect(cfg, tmpDir)
9292
require.NoError(t, err)
9393
require.NotNil(t, conn)
94-
defer conn.Close()
94+
defer func() { _ = conn.Close() }()
9595

9696
// Create server handler
9797
mux, err := server.NewServeMux(conn, cfg, tmpDir)

e2e/empty_body_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ func TestEmptyBody_AcceptsEmpty(t *testing.T) {
1919
configDir, _ := filepath.Abs(".")
2020
conn, err := db.Connect(cfg, configDir)
2121
require.NoError(t, err)
22-
defer conn.Close()
22+
defer func() { _ = conn.Close() }()
2323

2424
mux, err := server.NewServeMux(conn, cfg, configDir)
2525
require.NoError(t, err)

examples/stupid_todolist/config.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ mutations:
6767
sql: |
6868
INSERT INTO todos (title) VALUES (:title)
6969
RETURNING id, title, completed, created_at
70+
delay: 500ms
7071
transform:
7172
post: |
7273
response.status = 201;
@@ -79,6 +80,7 @@ mutations:
7980
sql: |
8081
UPDATE todos SET title = :title, completed = :completed WHERE id = :id
8182
RETURNING id, title, completed, created_at
83+
delay: 500ms
8284
transform:
8385
pre: |
8486
return {
@@ -93,6 +95,7 @@ mutations:
9395
method: DELETE
9496
path: /api/todos/{id:[0-9]+}
9597
sql: DELETE FROM todos WHERE id = :id
98+
delay: 500ms
9699
transform:
97100
post: |
98101
response.status = 204;

internal/db/db_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import (
1616
func TestExecuteInit_InlineSQL(t *testing.T) {
1717
db, err := sqlx.Open("sqlite", ":memory:")
1818
require.NoError(t, err)
19-
defer db.Close()
19+
defer func() { _ = db.Close() }()
2020

2121
cfg := config.Config{
2222
Database: &config.DatabaseConfig{
@@ -51,7 +51,7 @@ func TestExecuteInit_SQLFiles(t *testing.T) {
5151

5252
db, err := sqlx.Open("sqlite", ":memory:")
5353
require.NoError(t, err)
54-
defer db.Close()
54+
defer func() { _ = db.Close() }()
5555

5656
cfg := config.Config{
5757
Database: &config.DatabaseConfig{
@@ -85,7 +85,7 @@ func TestExecuteInit_BothSQLAndFiles(t *testing.T) {
8585

8686
db, err := sqlx.Open("sqlite", ":memory:")
8787
require.NoError(t, err)
88-
defer db.Close()
88+
defer func() { _ = db.Close() }()
8989

9090
cfg := config.Config{
9191
Database: &config.DatabaseConfig{
@@ -110,7 +110,7 @@ func TestExecuteInit_BothSQLAndFiles(t *testing.T) {
110110
func TestExecuteInit_NoInit(t *testing.T) {
111111
db, err := sqlx.Open("sqlite", ":memory:")
112112
require.NoError(t, err)
113-
defer db.Close()
113+
defer func() { _ = db.Close() }()
114114

115115
cfg := config.Config{
116116
Database: &config.DatabaseConfig{
@@ -125,7 +125,7 @@ func TestExecuteInit_NoInit(t *testing.T) {
125125
func TestExecuteInit_NilDatabase(t *testing.T) {
126126
db, err := sqlx.Open("sqlite", ":memory:")
127127
require.NoError(t, err)
128-
defer db.Close()
128+
defer func() { _ = db.Close() }()
129129

130130
cfg := config.Config{}
131131

@@ -136,7 +136,7 @@ func TestExecuteInit_NilDatabase(t *testing.T) {
136136
func TestExecuteInit_InvalidSQL(t *testing.T) {
137137
db, err := sqlx.Open("sqlite", ":memory:")
138138
require.NoError(t, err)
139-
defer db.Close()
139+
defer func() { _ = db.Close() }()
140140

141141
cfg := config.Config{
142142
Database: &config.DatabaseConfig{
@@ -155,7 +155,7 @@ func TestExecuteInit_InvalidSQL(t *testing.T) {
155155
func TestExecuteInit_MissingSQLFile(t *testing.T) {
156156
db, err := sqlx.Open("sqlite", ":memory:")
157157
require.NoError(t, err)
158-
defer db.Close()
158+
defer func() { _ = db.Close() }()
159159

160160
cfg := config.Config{
161161
Database: &config.DatabaseConfig{

0 commit comments

Comments
 (0)