fix: Fix color variables being passed.

Author: milesj

.yarn/versions/cd7505ac.yml

@@ -0,0 +1,9 @@
+releases:
+  "@moonrepo/cli": patch
+  "@moonrepo/core-linux-arm64-gnu": patch
+  "@moonrepo/core-linux-arm64-musl": patch
+  "@moonrepo/core-linux-x64-gnu": patch
+  "@moonrepo/core-linux-x64-musl": patch
+  "@moonrepo/core-macos-arm64": patch
+  "@moonrepo/core-macos-x64": patch
+  "@moonrepo/core-windows-x64-msvc": patch

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+#### 🐞 Fixes
+
+- Fixed an issue where `NO_COLOR` or `FORCE_COLOR` would be overwritten for task child processes.
+
 ## 1.32.1
 
 #### 🚀 Updates

crates/process/src/command.rs

@@ -138,12 +138,20 @@ impl Command {
     }
 
     pub fn inherit_colors(&mut self) -> &mut Self {
-        let level = color::supports_color().to_string();
-
+        // Don't show colors in our own tests, as it disrupts snapshots
         if !is_test_env() {
-            self.env_remove("NO_COLOR");
-            self.env("FORCE_COLOR", &level);
-            self.env("CLICOLOR_FORCE", &level);
+            let no_color = OsString::from("NO_COLOR");
+            let force_color = OsString::from("FORCE_COLOR");
+
+            // Only inherit colors if the current command hasn't
+            // explicitly configured these variables
+            if !self.env.contains_key(&no_color) && !self.env.contains_key(&force_color) {
+                let level = color::supports_color().to_string();
+
+                self.env_remove(no_color);
+                self.env(force_color, &level);
+                self.env("CLICOLOR_FORCE", &level);
+            }
         }
 
         // Force a terminal width so that we have consistent sizing

website/docs/commands/overview.mdx

@@ -87,10 +87,10 @@ $ MOON_CONCURRENCY=1 moon run app:build
 At minimum, most debugging can be done by passing [`--log trace`](#logging) on the command line and
 sifting through the logs. We also provide the following environment variables to toggle output.
 
-- `MOON_DEBUG_PROCESS_ENV` - By default moon hides the environment variables (except for `MOON` or
-  `PROTO`) passed to processes to avoid leaking sensitive information. However, knowing what
-  environment variables are passed around is helpful in debugging. Declare this variable to reveal
-  the entire environment.
+- `MOON_DEBUG_PROCESS_ENV` - By default moon hides the environment variables (except for `MOON_`)
+  passed to processes to avoid leaking sensitive information. However, knowing what environment
+  variables are passed around is helpful in debugging. Declare this variable to reveal the entire
+  environment.
 - `MOON_DEBUG_PROCESS_INPUT` - By default moon truncates the stdin passed to processes to avoid
   thrashing the console with a large input string. However, knowing what input is passed around is
   helpful in debugging. Declare this variable to reveal the entire input.