fix: move InstallLogger creation before scope init to prevent UnboundLocalError, add exit code assertion to --global test

Co-authored-by: sergio-sisternes-epam <207026618+sergio-sisternes-epam@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/apm/sessions/0920712b-bd70-4b27-a30e-55b6c1fe6700

Author: Copilot

src/apm_cli/commands/install.py

@@ -543,6 +543,12 @@ def install(ctx, packages, runtime, exclude, only, update, dry_run, force, verbo
         apm install -g org/pkg1                 # Install to user scope (~/.apm/)
     """
     try:
+        # Create structured logger for install output early so exception
+        # handlers can always reference it (avoids UnboundLocalError if
+        # scope initialisation below throws).
+        is_partial = bool(packages)
+        logger = InstallLogger(verbose=verbose, dry_run=dry_run, partial=is_partial)
+
         # Resolve scope
         from ..core.scope import InstallScope, get_deploy_root, get_apm_dir, get_manifest_path, get_modules_dir, ensure_user_dirs, warn_unsupported_user_scope
         scope = InstallScope.USER if global_ else InstallScope.PROJECT
@@ -561,10 +567,6 @@ def install(ctx, packages, runtime, exclude, only, update, dry_run, force, verbo
         # Display name for messages (short for project scope, full for user scope)
         manifest_display = str(manifest_path) if scope is InstallScope.USER else APM_YML_FILENAME
 
-        # Create structured logger for install output
-        is_partial = bool(packages)
-        logger = InstallLogger(verbose=verbose, dry_run=dry_run, partial=is_partial)
-
         # Check if apm.yml exists
         apm_yml_exists = manifest_path.exists()
 

tests/unit/test_install_command.py

@@ -635,6 +635,7 @@ def test_global_flag_shows_scope_info(self):
                 fake_home.mkdir()
                 with patch.object(Path, "home", return_value=fake_home):
                     result = self.runner.invoke(cli, ["install", "--global"])
+                assert result.exit_code == 1
                 assert "user scope" in result.output.lower() or "~/.apm/" in result.output
                 # Should warn about unsupported targets
                 assert "copilot" in result.output.lower()