Skip to content

Commit cb24ba7

Browse files
authored
fix: don't add secretName: "<nil>" to ingress if no value defined (#1635)
1 parent 3d4920d commit cb24ba7

3 files changed

Lines changed: 7 additions & 1 deletion

File tree

charts/jenkins/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ Use the following links to reference issues, PRs, and commits prior to v2.6.0.
1212
The changelog until v1.5.7 was auto-generated based on git commits.
1313
Those entries include a reference to the git commit to be able to get more details.
1414

15+
## 5.9.6
16+
17+
Don't add `secretName: "<nil>"` to ingress if no value defined
18+
1519
## 5.9.5
1620

1721
Don't render `tls` ingress section if its value is `{}`

charts/jenkins/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: jenkins
33
type: application
44
home: https://www.jenkins.io/
5-
version: 5.9.5
5+
version: 5.9.6
66
appVersion: 2.541.2
77
description: >
88
Jenkins - Build great things at any scale! As the leading open source automation server, Jenkins provides over 2000 plugins to support building, deploying and automating any project.

charts/jenkins/templates/jenkins-controller-ingress.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,10 @@ spec:
8181
{{- if $.Values.controller.ingress.resourceRootUrl }}
8282
- {{ tpl $.Values.controller.ingress.resourceRootUrl $ | quote }}
8383
{{- end }}
84+
{{- if .secretName }}
8485
secretName: {{ tpl (.secretName | toString) $ | quote }}
8586
{{- end }}
8687
{{- end }}
8788
{{- end }}
8889
{{- end }}
90+
{{- end }}

0 commit comments

Comments
 (0)