(release) v0.6.414 proper tracebacks

Author: hoffstadt

DearPyGui/src/core/PythonUtilities/mvPythonExceptions.cpp

@@ -11,17 +11,9 @@ namespace Marvel
 	void ThrowPythonException(const std::string& message)
 	{
 
-		std::string fullMessage = "Line: %d \t" + message;
+		std::string fullMessage = "Error: [%d] Message: \t" + message;
+		PyErr_Format(PyExc_Exception, fullMessage.c_str(), 1000);
 
-		int line = 0;
-		auto f = PyEval_GetFrame();
-		if (f)
-			line = PyFrame_GetLineNumber(f);
-		else
-			fullMessage.append(" || error occured in a callback");
-
-		PyErr_Format(PyExc_Exception, fullMessage.c_str(), line);
-		PyErr_Print();
 	}
 
 }

DearPyGui/src/core/PythonUtilities/mvPythonParser.cpp

@@ -124,18 +124,17 @@ namespace Marvel {
 		if (!PyArg_VaParseTupleAndKeywords(args, kwargs, m_formatstring.data(),
 			const_cast<char**>(m_keywords.data()), arguments))
 		{
-			PyErr_Print();
 			check = false;
-			mvAppLog::Show();
-			int line = PyFrame_GetLineNumber(PyEval_GetFrame());
-			PyObject* ex = PyErr_Format(PyExc_Exception,
-				"Error parsing DearPyGui %s command on line %d.", message, line);
-			PyErr_Print();
-			Py_XDECREF(ex);
 		}
 
 		va_end(arguments);
 
+		if (!check)
+		{
+			mvAppLog::Show();
+			ThrowPythonException("Error parsing Dear PyGui command: " + std::string(message));
+		}
+
 		return check;
 	}
 

DearPyGui/src/core/Registries/mvCallbackRegistry.cpp

@@ -228,6 +228,7 @@ namespace Marvel {
 			if (data != nullptr)
 				Py_XDECREF(data);
 			ThrowPythonException("Callable not callable.");
+			PyErr_Print();
 			return;
 		}
 
@@ -239,7 +240,7 @@ namespace Marvel {
 
 		Py_XINCREF(data);
 
-		PyErr_Clear();
+		//PyErr_Clear();
 
 		PyObject* intermediateResult = nullptr;
 		if (PyCallable_Check(data))
@@ -249,18 +250,15 @@ namespace Marvel {
 			if (intermediateResult == nullptr)
 			{
 				PyErr_Print();
-				ThrowPythonException("Callable data failed");
+				//ThrowPythonException("Callable data failed");
 				intermediateResult = data;
 			}
 
-			// check if error occurred
-			if (PyErr_Occurred())
-				PyErr_Print();
 		}
 		else
 			intermediateResult = data;
 
-		PyErr_Clear();
+		//PyErr_Clear();
 
 		PyObject* fc = PyObject_GetAttrString(callable, "__code__");
 		if (fc) {
@@ -286,7 +284,7 @@ namespace Marvel {
 					if (!result.isOk())
 					{
 						PyErr_Print();
-						ThrowPythonException("Callable failed");
+						//ThrowPythonException("Callable failed");
 					}
 
 				}
@@ -302,7 +300,7 @@ namespace Marvel {
 					if (!result.isOk())
 					{
 						PyErr_Print();
-						ThrowPythonException("Callable failed");
+						//ThrowPythonException("Callable failed");
 					}
 
 				}
@@ -317,7 +315,7 @@ namespace Marvel {
 					if (!result.isOk())
 					{
 						PyErr_Print();
-						ThrowPythonException("Callable failed");
+						//ThrowPythonException("Callable failed");
 					}
 				}
 				else
@@ -328,7 +326,7 @@ namespace Marvel {
 					if (!result.isOk())
 					{
 						PyErr_Print();
-						ThrowPythonException("Callable failed");
+						//ThrowPythonException("Callable failed");
 					}
 
 

docs/CHANGELOG.txt

@@ -22,6 +22,13 @@ HOW TO UPDATE?
 - Read the `Breaking Changes` section (here in the changelog).
 - Please report any issue!
 
+------------------------------------------------------------------------
+ VERSION 0.6.414
+------------------------------------------------------------------------
+Fixes:
+
+- added proper tracebacks
+
 ------------------------------------------------------------------------
  VERSION 0.6.403
 ------------------------------------------------------------------------