Skip to content

Commit 21a5a1a

Browse files
committed
do not re-classify monitored fields (#6236)
1 parent d511d02 commit 21a5a1a

3 files changed

Lines changed: 11 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
2424

2525
## [2.63.3](https://github.com/ethyca/fides/compare/2.63.2...2.63.3)
2626

27+
### Changed
28+
- Updated the `re-classify` button to avoid sending `monitored` fields back to classification [#6236](https://github.com/ethyca/fides/pull/6236)
2729

2830
## [2.63.2](https://github.com/ethyca/fides/compare/2.63.1...2.63.2)
2931

clients/admin-ui/src/features/data-discovery-and-detection/discovery-detection.slice.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ const discoveryDetectionApi = baseApi.injectEndpoints({
138138
unmute_children?: boolean;
139139
start_classification?: boolean;
140140
classify_monitored_resources?: boolean;
141+
diff_statuses_to_classify?: DiffStatus[];
141142
}
142143
>({
143144
query: (params) => ({
@@ -146,6 +147,7 @@ const discoveryDetectionApi = baseApi.injectEndpoints({
146147
{
147148
unmute_children: params.unmute_children,
148149
classify_monitored_resources: params.classify_monitored_resources,
150+
diff_statuses_to_classify: params.diff_statuses_to_classify,
149151
},
150152
{ arrayFormat: "none" },
151153
)}`,

clients/admin-ui/src/features/data-discovery-and-detection/tables/cells/DiscoveryItemActionsCell.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,13 @@ const DiscoveryItemActionsCell = ({ resource }: DiscoveryItemActionsProps) => {
109109
staged_resource_urn: resource.urn,
110110
monitor_config_id: resource.monitor_config_id!,
111111
start_classification: true,
112-
classify_monitored_resources: true,
112+
// these are the diff statuses of resources that should be sent to 're-classification'
113+
diff_statuses_to_classify: [
114+
DiffStatus.CLASSIFICATION_ADDITION,
115+
DiffStatus.CLASSIFICATION_UPDATE,
116+
DiffStatus.CLASSIFYING,
117+
DiffStatus.CLASSIFICATION_QUEUED,
118+
],
113119
});
114120
if (isErrorResult(result)) {
115121
errorAlert(

0 commit comments

Comments
 (0)