fix(update): dismiss better

Author: kentcdodds

packages/workshop-app/app/root.tsx

@@ -138,7 +138,7 @@ export async function loader({ request }: LoaderFunctionArgs) {
 	if (
 		repoUpdates &&
 		repoUpdates.remoteCommit &&
-		mutedNotifications.includes(repoUpdates.remoteCommit)
+		mutedNotifications.includes(`update-repo-${repoUpdates.remoteCommit}`)
 	) {
 		repoUpdates = { ...repoUpdates, updatesAvailable: false }
 	}

packages/workshop-app/app/routes/admin+/update-repo.tsx

@@ -15,7 +15,7 @@ export async function action({ request }: { request: Request }) {
 	const id = formData.get('id')
 
 	if (intent === 'dismiss' && typeof id === 'string') {
-		await muteNotification(id)
+		await muteNotification(`update-repo-${id}`)
 		return json({ type: 'dismissed' } as const)
 	}
 
@@ -59,6 +59,8 @@ export function UpdateToast({
 }) {
 	const updateFetcher = useFetcher<typeof action>()
 	const updateFetcherRef = useRef(updateFetcher)
+	const dismissFetcher = useFetcher<typeof action>()
+	const dismissFetcherRef = useRef(dismissFetcher)
 	const { updatesAvailable, diffLink, remoteCommit } = repoUpdates
 
 	useEffect(() => {
@@ -84,7 +86,7 @@ export function UpdateToast({
 					const formData = new FormData()
 					formData.append('intent', 'dismiss')
 					formData.append('id', remoteCommit)
-					updateFetcherRef.current.submit(formData, {
+					dismissFetcherRef.current.submit(formData, {
 						method: 'post',
 						action: '/admin/update-repo',
 					})