Skip to content

Commit 4bede03

Browse files
committed
adding more error catching
1 parent e067a11 commit 4bede03

9 files changed

Lines changed: 32 additions & 6 deletions

lib/errors/auth_error.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
module Errors
2+
class AuthError < StandardError
3+
end
4+
end

lib/errors/bad_content.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
module Errors
2+
class BadContent < StandardError
3+
end
4+
end

lib/errors/invalid_format.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
module Errors
2+
class InvalidFormat < StandardError
3+
end
4+
end

lib/errors/not_found.rb

Lines changed: 0 additions & 4 deletions
This file was deleted.

lib/errors/raise_error.rb

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,16 @@ module Errors
22
class RaiseError < Faraday::Response::Middleware
33

44
def on_complete(env)
5-
raise Errors::NotFound if env[:status] == 404
6-
raise Errors::AuthError if env[:status] == 401
5+
case env[:status]
6+
when 429
7+
raise Errors::RateLimitExceeded
8+
when 404
9+
raise Errors::ResourceNotFound
10+
when 401
11+
raise Errors::AuthError
12+
when 400
13+
raise Errors::BadContent
14+
end
715
end
816

917
end

lib/errors/rate_limit_exceeded.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
module Errors
2+
class RateLimitExceeded < StandardError
3+
end
4+
end

lib/errors/resource_not_found.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
module Errors
2+
class ResourceNotFound < StandardError
3+
end
4+
end

open_calais.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,5 @@ Gem::Specification.new do |gem|
3030
gem.add_development_dependency('minitest')
3131
gem.add_development_dependency('simplecov')
3232
gem.add_development_dependency('coveralls')
33+
gem.add_development_dependency('byebug')
3334
end

test/test_helper.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@
1010

1111
require 'minitest/spec'
1212
require 'minitest/autorun'
13+
require 'byebug'
1314

1415
require 'open_calais'

0 commit comments

Comments
 (0)