CMS-2044 - Ensure legacy plugin settings get saved correctly

Author: riasvdv

yii2-adapter/legacy/services/Plugins.php

@@ -251,6 +251,16 @@ public function switchEdition(string $handle, string $edition): void
      */
     public function savePluginSettings(PluginInterface $plugin, array $settings): bool
     {
+        if (is_null($pluginSettings = $plugin->getSettings())) {
+            return false;
+        }
+
+        /**
+         * We override this as the legacy service needs
+         * to save with setting safeOnly to `false`.
+         */
+        $pluginSettings->setAttributes($settings, false);
+
         return app(PluginsService::class)->savePluginSettings($plugin, $settings);
     }