Skip to content

Commit 229285f

Browse files
committed
Fix general config not being loaded
1 parent c44de69 commit 229285f

3 files changed

Lines changed: 11 additions & 1 deletion

File tree

src/Config/ConfigServiceProvider.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ public function register(): void
2222
{
2323
Env::extend(fn () => ConstAdapter::class);
2424

25-
$this->app->bind(GeneralConfig::class, fn () => Config::get('craft.general'));
25+
$this->app->singleton(GeneralConfig::class, function () {
26+
return $this->app['config']->get('craft.general');
27+
});
2628
}
2729

2830
public function boot(): void

src/Config/GeneralConfig.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
use Illuminate\Http\Middleware\TrustProxies;
1515
use Illuminate\Http\Request;
1616
use Illuminate\Support\Facades\Config;
17+
use Illuminate\Support\Traits\Conditionable;
1718
use yii\base\InvalidArgumentException;
1819
use yii\base\InvalidConfigException;
1920

@@ -22,6 +23,8 @@
2223
*/
2324
class GeneralConfig extends BaseConfig
2425
{
26+
use Conditionable;
27+
2528
public const IMAGE_DRIVER_AUTO = 'auto';
2629

2730
public const IMAGE_DRIVER_GD = 'gd';

yii2-adapter/src/Yii2ServiceProvider.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
use craft\utilities\AssetIndexes;
1414
use craft\utilities\ClearCaches;
1515
use CraftCms\Aliases\Aliases;
16+
use CraftCms\Cms\Config\BaseConfig;
1617
use CraftCms\Cms\Config\GeneralConfig;
1718
use CraftCms\Cms\Database\Table;
1819
use CraftCms\Cms\Edition\Events\EditionChanged;
@@ -61,6 +62,10 @@ protected function registerMultiEnvironmentConfigs(): void
6162
$key = "craft.{$file->getFilenameWithoutExtension()}";
6263
$config = Config::get($key);
6364

65+
if ($config instanceof BaseConfig) {
66+
continue;
67+
}
68+
6469
if (!is_array($config)) {
6570
Config::set($key, []);
6671
continue;

0 commit comments

Comments
 (0)