Builds failing when codecov cannot upload coverage metrics

[LocoDelAssembly]

I'm getting somewhat frequently today errors like uri/common.rb:739:in 'URI': bad argument (expected URI object or URI string) (ArgumentError)

It looks the problem comes from here:

codecov-ruby/lib/codecov.rb

Line 413 in e1b4e2f

uri = URI(s3target)

However, I was wondering if it is OK when codecov fails to cause the tests to fail? Is there an official way to prevent returning non-zero exit status when this happen?

[tetienne]

Any workaround about this? It break our CI workflow a lot of time.

[tetienne]

  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _\`|/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                               Ruby-0.2.11
==> Circle CI detected
==> Appending file network
==> Gzipping contents
==> Uploading reports
    url:   https://codecov.io
    query: token=secret&flags=backend&package=ruby-0.2.11&service=circleci&build=xxxxxx&job=25&slug=xxxxxx&pr&branch=xxxxxxx&commit=xxxxxxx
->  Pinging Codecov
https://codecov.io/upload/v4?token=secret&flags=backend&package=ruby-0.2.11&service=circleci&build=xxxx&job=25&slug=xxxxxxxx&pr&branch=xxxxxxxx&commit=e593ef5a51cd913c117415cdc220b6cee81b6f55
->  Uploading to

Traceback (most recent call last):
	8: from /home/circleci/livestorm/packages/backend/vendor/bundle/ruby/2.7.0/gems/simplecov-0.19.0/lib/simplecov/defaults.rb:27:in `block in <top (required)>'
	7: from /home/circleci/livestorm/packages/backend/vendor/bundle/ruby/2.7.0/gems/simplecov-0.19.0/lib/simplecov.rb:179:in `at_exit_behavior'
	6: from /home/circleci/livestorm/packages/backend/vendor/bundle/ruby/2.7.0/gems/simplecov-0.19.0/lib/simplecov.rb:189:in `run_exit_tasks!'
	5: from /home/circleci/livestorm/packages/backend/vendor/bundle/ruby/2.7.0/gems/simplecov-0.19.0/lib/simplecov/configuration.rb:196:in `block in at_exit'
	4: from /home/circleci/livestorm/packages/backend/vendor/bundle/ruby/2.7.0/gems/simplecov-0.19.0/lib/simplecov/result.rb:51:in `format!'
	3: from /home/circleci/livestorm/packages/backend/vendor/bundle/ruby/2.7.0/gems/codecov-0.2.11/lib/codecov.rb:470:in `format'
	2: from /home/circleci/livestorm/packages/backend/vendor/bundle/ruby/2.7.0/gems/codecov-0.2.11/lib/codecov.rb:372:in `upload_to_codecov'
	1: from /home/circleci/livestorm/packages/backend/vendor/bundle/ruby/2.7.0/gems/codecov-0.2.11/lib/codecov.rb:406:in `upload_to_v4'
/usr/local/lib/ruby/2.7.0/uri/common.rb:739:in `URI': bad argument (expected URI object or URI string) (ArgumentError)

Exited with code exit status 1

CircleCI received exit code 1

[thomasrockhu]

@tetienne, would you be able to post a link to the CircleCI build here?

[LocoDelAssembly]

@thomasrockhu In case it is useful an example with GitHub Action: https://github.com/SpeciesFileGroup/taxonworks/runs/1899691952?check_suite_focus=true

[thomasrockhu]

@LocoDelAssembly that is helpful, can try installing the GitHub app here?

[tetienne]

@thomasrockhu That’s from a private circleci instance, so you cannot access it. If you need specific information, don’t hesitate to ask me.

[nilleb]

The problem seems to be in

codecov-ruby/lib/codecov/uploader.rb

Line 424 in e0aa49e

if !response&.code || response.code == '400'

=> the response can not be parsed as a valid url

Since visibly it's the second time this week that the platform has problems (according to https://status.codecov.io/) that prevent paying customers from uploading reports, would it be possible to make the upload NON blocking? I can live without the codecov.io reports, but I would prefer my CI checks to pass all the same. Maybe adding a SimpleCov option?

[thomasrockhu]

Hi all, I'll keep this ticket open for a few weeks, but we released 0.5.0 which should help address this issue. You can set SimpleCov.pass_ci_if_error = true in a .simplecov or _helper.rb file.

Let me know if that works for you or if you experience issues.

[elia]

With the latest update we're consistently getting this error, I believe the syntax error is in something returned by the server:

->  Pinging Codecov
https://codecov.io/upload/v4?token=secret&flags&package=ruby-0.5.0&service=circleci&build=5978&job=0&slug=team-cometeer%2Fcometeer&pr&branch=master&commit=123abcxxxxxxxxxxxx
->  Uploading to

sh: 1: Syntax error: "(" unexpected

sh: 2: Syntax error: Unterminated quoted string

Traceback (most recent call last):
	9: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/simplecov-0.21.2/lib/simplecov/defaults.rb:30:in `block in <top (required)>'
	8: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/simplecov-0.21.2/lib/simplecov.rb:179:in `at_exit_behavior'
	7: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/simplecov-0.21.2/lib/simplecov.rb:189:in `run_exit_tasks!'
	6: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/simplecov-0.21.2/lib/simplecov/configuration.rb:197:in `block in at_exit'
	5: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/simplecov-0.21.2/lib/simplecov/result.rb:51:in `format!'
	4: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/codecov-0.5.0/lib/codecov.rb:15:in `format'
	3: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/codecov-0.5.0/lib/codecov/uploader.rb:42:in `upload'
	2: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/codecov-0.5.0/lib/codecov/uploader.rb:410:in `upload_to_codecov'
	1: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/codecov-0.5.0/lib/codecov/uploader.rb:444:in `upload_to_v4'
/usr/local/lib/ruby/2.7.0/uri/common.rb:739:in `URI': bad argument (expected URI object or URI string) (ArgumentError)
	7: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/simplecov-0.21.2/lib/simplecov/defaults.rb:30:in `block in <top (required)>'
	6: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/simplecov-0.21.2/lib/simplecov.rb:179:in `at_exit_behavior'
	5: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/simplecov-0.21.2/lib/simplecov.rb:189:in `run_exit_tasks!'
	4: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/simplecov-0.21.2/lib/simplecov/configuration.rb:197:in `block in at_exit'
	3: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/simplecov-0.21.2/lib/simplecov/result.rb:51:in `format!'
	2: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/codecov-0.5.0/lib/codecov.rb:15:in `format'
	1: from /home/circleci/project/vendor/bundle/ruby/2.7.0/gems/codecov-0.5.0/lib/codecov/uploader.rb:41:in `upload'
/home/circleci/project/vendor/bundle/ruby/2.7.0/gems/codecov-0.5.0/lib/codecov/uploader.rb:46:in `rescue in upload': undefined method `pass_ci_if_error' for SimpleCov:Module (NoMethodError)

[nilleb]

hello @thomasrockhu

Sorry, but I experience issues

An error occurred while loading ./spec/controllers/api/graphql/emails/actions_controller_spec.rb.
Failure/Error: SimpleCov.pass_ci_if_error = true

NoMethodError:
  undefined method `pass_ci_if_error=' for SimpleCov:Module

In a very similar way to the comment https://github.com/codecov/codecov-ruby/pull/137/files#r585093609 (on the PR that has been merged two days ago).

Am I missing something?

[thomasrockhu]

@nilleb no, this is definitely my fault. #138 should address it

[thomasrockhu]

@nilleb it should work on 0.5.1 with Codecov.pass_ci_if_error = true

[AlexWayfer]

@nilleb it should work on 0.5.1 with Codecov.pass_ci_if_error = true

The default is nil? Why this build has passed? https://cirrus-ci.com/task/5728180502790144?command=test#L167