fix: further CI/CD enhancements for nuget flow

Author: Spelkington

.github/workflows/publish.yml

@@ -12,11 +12,6 @@ jobs:
       contents: read
 
     steps:
-      - name: Checkout release tag
-        uses: actions/checkout@v4
-        with:
-          ref: ${{ github.ref }}
-
       - name: Setup .NET
         uses: actions/setup-dotnet@v4
         with:
@@ -27,36 +22,15 @@ jobs:
           DOTNET_NOLOGO: "true"
           DOTNET_CLI_TELEMETRY_OPTOUT: "true"
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: "22"
-
-      - name: Setup pnpm
-        uses: pnpm/action-setup@v4
-        with:
-          version: 10.6.3
-
-      - name: Cache NuGet packages
-        uses: actions/cache@v4
-        with:
-          path: ~/.nuget/packages
-          key: ${{ runner.os }}-nuget-${{ hashFiles('**/packages.lock.json', '**/*.csproj') }}
-          restore-keys: |
-            ${{ runner.os }}-nuget-
-
-      - name: Install dependencies
-        run: pnpm install
-
-      - name: Stamp release version into Directory.Build.props
+      - name: Download NuGet packages from release
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          VERSION="${{ github.ref_name }}"
-          VERSION="${VERSION#v}"
-          sed -i "s|<Version>.*</Version>|<Version>${VERSION}</Version>|" Directory.Build.props
-          echo "Stamped version: ${VERSION}"
-
-      - name: Build and pack NuGet packages
-        run: pnpm nx run-many -t pack
+          mkdir -p dist/packages
+          gh release download "${{ github.ref_name }}" \
+            --pattern "*.nupkg" \
+            --dir dist/packages \
+            --repo "${{ github.repository }}"
 
       - name: Publish to NuGet
         run: |

.github/workflows/release.yml

@@ -170,6 +170,34 @@ jobs:
             --notes "${NOTES}" \
             --draft
 
+      - name: Pack NuGet packages (release version)
+        if: steps.release.outputs.changed == 'true'
+        run: pnpm nx run-many -t pack
+
+      - name: Upload packages to GitHub release
+        if: steps.release.outputs.changed == 'true'
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          VERSION="v${{ steps.release.outputs.version }}"
+          gh release upload "${VERSION}" dist/packages/*.nupkg
+
+      - name: Publish preview to NuGet
+        if: steps.release.outputs.changed == 'true'
+        env:
+          FLOWTHRU_NUGET_API_KEY: ${{ secrets.FLOWTHRU_NUGET_API_KEY }}
+        run: |
+          VERSION="${{ steps.release.outputs.version }}"
+          PRERELEASE_VERSION="${VERSION}-preview.${{ github.run_number }}"
+          sed -i "s|<Version>.*</Version>|<Version>${PRERELEASE_VERSION}</Version>|" Directory.Build.props
+          rm dist/packages/*.nupkg
+          pnpm nx run-many -t pack
+          sed -i "s|<Version>.*</Version>|<Version>${VERSION}</Version>|" Directory.Build.props
+          dotnet nuget push "dist/packages/*.nupkg" \
+            --api-key "${FLOWTHRU_NUGET_API_KEY}" \
+            --source https://api.nuget.org/v3/index.json \
+            --skip-duplicate
+
       - name: Install Copilot CLI
         if: steps.release.outputs.changed == 'true'
         run: npm install -g @github/copilot
@@ -218,23 +246,6 @@ jobs:
             gh release edit "${VERSION}" --notes-file /tmp/combined-notes.md
           fi
 
-      - name: Publish prerelease to NuGet
-        if: steps.release.outputs.changed == 'true'
-        env:
-          FLOWTHRU_NUGET_API_KEY: ${{ secrets.FLOWTHRU_NUGET_API_KEY }}
-        run: |
-          VERSION="${{ steps.release.outputs.version }}"
-          PRERELEASE_VERSION="${VERSION}-preview.${{ github.run_number }}"
-          # Override version in Directory.Build.props for the prerelease pack only.
-          # This file was already committed and pushed — this mutation is ephemeral.
-          sed -i "s|<Version>.*</Version>|<Version>${PRERELEASE_VERSION}</Version>|" Directory.Build.props
-          pnpm nx run-many -t pack
-          sed -i "s|<Version>.*</Version>|<Version>${VERSION}</Version>|" Directory.Build.props
-          dotnet nuget push "dist/packages/*.nupkg" \
-            --api-key "${FLOWTHRU_NUGET_API_KEY}" \
-            --source https://api.nuget.org/v3/index.json \
-            --skip-duplicate
-
       - name: Upload coverage badges as artifact
         if: always()
         uses: actions/upload-artifact@v4