Skip to content

Commit 3393392

Browse files
committed
fix: Address PR review bot comments
- Lowercase PUT → put for HTTP method consistency - Remove redundant ?? [] null coalescing on already-filtered body - Fix $prfileId typo → $profileId in test
1 parent 0514d97 commit 3393392

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/API/Management/SelfServiceProfiles.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,10 +175,10 @@ public function setCustomTextForProfile(
175175
])->isString();
176176

177177
return $this->getHttpClient()
178-
->method('PUT')
178+
->method('put')
179179
->addPath(['self-service-profiles', $id, 'custom-text', $language, $page])
180180
->withOptions($options)
181-
->withBody($body ?? [])
181+
->withBody($body)
182182
->call();
183183
}
184184

tests/Unit/API/Management/SelfSerivceProfiles.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,12 +166,12 @@
166166

167167
test('revokeSsoTicket() issues an appropriate request', function(): void {
168168
$id = uniqid();
169-
$prfileId = uniqid();
169+
$profileId = uniqid();
170170

171-
$this->endpoint->revokeSsoTicket($id, $prfileId);
171+
$this->endpoint->revokeSsoTicket($id, $profileId);
172172

173173
expect($this->api->getRequestMethod())->toEqual('POST');
174-
expect($this->api->getRequestUrl())->toEndWith('/api/v2/self-service-profiles/' . $id . '/sso-ticket/' . $prfileId . '/revoke');
174+
expect($this->api->getRequestUrl())->toEndWith('/api/v2/self-service-profiles/' . $id . '/sso-ticket/' . $profileId . '/revoke');
175175

176176
$headers = $this->api->getRequestHeaders();
177177
expect($headers['Content-Type'][0])->toEqual('application/json');

0 commit comments

Comments
 (0)