May the force be with us, close #4

Author: arabcoders

src/Error.php

@@ -179,7 +179,6 @@ public function setStructured( StructuredInterface $structured ) : ErrorInterfac
      */
     public function getStructured() : StructuredInterface
     {
-
         return $this->structured;
     }
 
@@ -250,7 +249,7 @@ public function register() : ErrorInterface
      */
     public function handleError( ErrorMapInterface $error ) : ErrorInterface
     {
-        // error was suppressed with the @-operator
+        // check if the error was suppressed with the @-operator and it's not fatal error.
         if ( 0 === error_reporting() && !in_array( $error->getNumber(), self::FATAL_ERRORS ) )
         {
             return $this;
@@ -424,7 +423,6 @@ public function addPolicy( string $name, PolicyInterface $policy ) : ErrorInterf
      */
     public function deletePolicy( $parameter, string $name ) : ErrorInterface
     {
-
         if ( !array_key_exists( $parameter, $this->policies ) )
         {
             throw new \InvalidArgumentException( sprintf( '(%s) has no registered Policies.', $parameter ) );
@@ -499,7 +497,6 @@ protected function log( $parameter ) : ErrorInterface
      */
     protected function display( $parameter ) : ErrorInterface
     {
-
         if ( array_key_exists( $parameter, $this->policies ) )
         {
             foreach ( $this->policies[$parameter] as $policy )
@@ -527,7 +524,6 @@ protected function display( $parameter ) : ErrorInterface
      */
     protected function exit( $parameter ) : ErrorInterface
     {
-
         if ( array_key_exists( $parameter, $this->policies ) )
         {
             foreach ( $this->policies[$parameter] as $policy )

src/Map.php

@@ -81,7 +81,7 @@ public function getType() : int
      */
     public function isError() : bool
     {
-        return $this->getType() === ErrorInterface::TYPE_ERROR;
+        return ErrorInterface::TYPE_ERROR === $this->getType();
     }
 
     /**
@@ -91,7 +91,7 @@ public function isError() : bool
      */
     public function isException() : bool
     {
-        return $this->getType() === ErrorInterface::TYPE_EXCEPTION;
+        return ErrorInterface::TYPE_EXCEPTION === $this->getType();
     }
 
     /**

src/Output/HTML.php

@@ -70,7 +70,7 @@ public function display() : OutputInterface
             $structured = '';
         }
 
-        $type = ( $this->getMap()->getType() == ErrorInterface::TYPE_ERROR ) ? 'Error' : 'Exception';
+        $type = ( ErrorInterface::TYPE_ERROR === $this->getMap()->getType() ) ? 'Error' : 'Exception';
 
         print sprintf( $string, $type, $this->escapeString( $this->getMap()->getMessage() ), $structured, $trace );
 

src/Output/Twig.php

@@ -70,7 +70,7 @@ public function display() : OutputInterface
 
         $structured = $this->getMap()->getStructured();
 
-        if ( $this->getMap()->getType() === ErrorInterface::TYPE_EXCEPTION )
+        if ( ErrorInterface::TYPE_EXCEPTION === $this->getMap()->getType() )
         {
             $class = get_class( $this->getMap()->getException() );
             $type  = ( new \ReflectionClass( $class ) )->getShortName();

src/Policy.php

@@ -64,7 +64,7 @@ public function __construct( int $type, $parameter, bool $logging, bool $display
     {
         if ( !is_string( $parameter ) && !is_int( $parameter ) )
         {
-            throw new \InvalidArgumentException( 'Parameter Type is not string or int.' );
+            throw new \InvalidArgumentException( '$parameter has to be (String)"Class FQN" or an (int)"Error Number"' );
         }
 
         $this->type       = $type;

src/Tracer.php

@@ -124,7 +124,7 @@ public function process() : TracerInterface
 
             foreach ( $this->ignore as $file )
             {
-                if ( stripos( $file, $trace['file'] ) !== false )
+                if ( false !== stripos( $file, $trace['file'] ) )
                 {
                     continue 2;
                 }