fix(server): fix match no index#3039
Open
LegendPei wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
This PR fixes a
NoIndexExceptiontriggered bymatch()traversals when precedinghas()filters contain index-required predicates such asneq()or range predicates but the related properties are not indexed.In this case, HugeGraph extracted these filters into
HugeGraphStepand pushed them into backendConditionQuery, causing backend index validation to reject the traversal before TinkerPop could evaluate the filters normally.Main Changes
Avoid extracting
HasStepfilters intoHugeGraphStepwhen:match(), andhas()predicate containsneq,gt,gte,lt, orlte.Keep those filters in the traversal so they are evaluated by the normal TinkerPop filter path instead of being forced into backend index query planning.
Add a regression test covering the
match()+ no-index condition scenario from [Bug] NoIndexException triggered by match()-step #2936.Verifying these changes
mvn test -pl hugegraph-server/hugegraph-test -am -P core-test,rocksdb -Dtest=CountStrategyCoreTest#testMatchWithNoIndexConditionMatchesDirectTraversal -DfailIfNoTests=falsemvn test -pl hugegraph-server/hugegraph-test -am -P core-test,rocksdb -Dtest=CountStrategyCoreTest -DfailIfNoTests=falseDoes this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need