Skip to content

Allow apache-beam[gcp] to resolve with google-cloud-storage 3.x#38135

Merged
shunping merged 1 commit intoapache:masterfrom
officialasishkumar:update-gcs-storage-bound
May 4, 2026
Merged

Allow apache-beam[gcp] to resolve with google-cloud-storage 3.x#38135
shunping merged 1 commit intoapache:masterfrom
officialasishkumar:update-gcs-storage-bound

Conversation

@officialasishkumar
Copy link
Copy Markdown
Contributor

Fixes #38127.

This widens the Python gcp extra's google-cloud-storage upper bound from <3 to <4 so apache-beam[gcp] can resolve alongside current gcsfs releases, which now require google-cloud-storage>=3.7.0.

Validation:

  • Reproduced the resolver failure before the change with a local pip install --dry-run against the Python SDK package and gcsfs==2026.1.0
  • Confirmed the same resolver run succeeds after the change and selects google-cloud-storage 3.10.1
  • Smoke-checked the Beam-used google-cloud-storage==3.7.0 APIs locally (Client, BlobReader, BlobWriter, DEFAULT_RETRY, _should_retry)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the dependency constraints for the Google Cloud Storage client library within the Apache Beam Python SDK. By loosening the upper bound, the project ensures better compatibility with modern ecosystem requirements and resolves dependency resolution conflicts encountered during installation.

Highlights

  • Dependency Update: Updated the upper bound for the google-cloud-storage dependency in the Python SDK setup configuration.
  • Compatibility: Increased the version constraint from <3 to <4 to allow compatibility with newer gcsfs releases.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the python label Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Copy Markdown

@dominic-cohere dominic-cohere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @claudevdm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @claudevdm

Copy link
Copy Markdown
Collaborator

@claudevdm claudevdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check the failing macos tests?

@claudevdm
Copy link
Copy Markdown
Collaborator

R: @shunping can you also please take a look since you are familiar with gcs usage in python sdk? Are there any other validations we should do here?

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@officialasishkumar officialasishkumar force-pushed the update-gcs-storage-bound branch from aeef2af to 3a079bd Compare April 25, 2026 22:13
@officialasishkumar
Copy link
Copy Markdown
Contributor Author

Checked the failing macOS tests and rebased in 3a079bd. The failure was from the stale base missing the pydot test extra; the PR diff still only widens the google-cloud-storage bound.

@shunping
Copy link
Copy Markdown
Collaborator

R: @shunping can you also please take a look since you are familiar with gcs usage in python sdk? Are there any other validations we should do here?

I am fine with the change as long as the tests run fine. Could you rebase to the master to pick up some fixes at #38289.

@officialasishkumar officialasishkumar force-pushed the update-gcs-storage-bound branch from 3a079bd to 0b6e04c Compare April 29, 2026 21:08
@officialasishkumar
Copy link
Copy Markdown
Contributor Author

Rebased onto current master and force-pushed 0b6e04c.

@shunping
Copy link
Copy Markdown
Collaborator

shunping commented May 4, 2026

Rebased onto current master and force-pushed 0b6e04c.

Thanks! Rerunning tests now.

@shunping shunping merged commit 010c52f into apache:master May 4, 2026
130 of 139 checks passed
@shunping
Copy link
Copy Markdown
Collaborator

shunping commented May 4, 2026

Done! Thanks for contributing, @officialasishkumar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Update stale python sdk google-cloud-storage dependency

4 participants