Skip to content

[Java] Further simplify MoreFutures usage in case it is cause of issues with ForkJoin pool stuckness#35673

Merged
scwhittle merged 1 commit intoapache:masterfrom
scwhittle:simpler_futures
Jul 28, 2025
Merged

[Java] Further simplify MoreFutures usage in case it is cause of issues with ForkJoin pool stuckness#35673
scwhittle merged 1 commit intoapache:masterfrom
scwhittle:simpler_futures

Conversation

@scwhittle
Copy link
Copy Markdown
Contributor

With 2.63 we still observed a pipeline stuck in WriteShardsIntoTempFilesFn joining with no apparent activity on the ForkJoinPool.

Thus #29926 may still exist, perhaps just less common. This change further simplifies the futures constructed since we don't require the list and perhaps there is some edge case on joining a future contributing the allof future within a chained apply. We don't need the returned list in this case so can delegate just to CompletableFutures.allof alone.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@scwhittle
Copy link
Copy Markdown
Contributor Author

R: @Abacn
since you reviewed #33042

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@scwhittle scwhittle merged commit 4043c90 into apache:master Jul 28, 2025
23 checks passed
@scwhittle scwhittle deleted the simpler_futures branch July 28, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants