Skip to content

Commit dc43be8

Browse files
authored
chore: add error logging in ingress (#428)
1 parent 76bfd45 commit dc43be8

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

pkg/ingress/ingress.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,13 @@ func (c *ingressController) sync(ctx context.Context, ev *types.Event) error {
172172
}
173173
added, updated, deleted = m.diff(om)
174174
}
175-
return c.controller.syncManifests(ctx, added, updated, deleted)
175+
if err := c.controller.syncManifests(ctx, added, updated, deleted); err != nil {
176+
log.Errorw("failed to sync ingress artifacts",
177+
zap.Error(err),
178+
)
179+
return err
180+
}
181+
return nil
176182
}
177183

178184
func (c *ingressController) handleSyncErr(obj interface{}, err error) {
@@ -201,11 +207,11 @@ func (c *ingressController) onAdd(obj interface{}) {
201207
valid := c.isIngressEffective(ing)
202208
if valid {
203209
log.Debugw("ingress add event arrived",
204-
zap.Any("object", obj),
210+
zap.Any("object", ing),
205211
)
206212
} else {
207213
log.Debugw("ignore noneffective ingress add event",
208-
zap.Any("object", obj),
214+
zap.Any("object", ing),
209215
)
210216
return
211217
}

0 commit comments

Comments
 (0)