Skip to content

VMAlertManager templates not passed through to config secret #2121

@P-n-I

Description

@P-n-I

Since the recent upgrade to victoria-metrics-k8s-stack >v0.75.0 operator v0.69.0 the monzo templates that the chart adds to the VMAlertManager resource aren't getting passed through to the generated Secret.

VMAlertManager snip:

spec:
  configSecret: vmalertmanager-<NAME>-vmstack
  externalURL: ""
  image:
    tag: v0.32.0
  port: "9093"
  replicaCount: 1
  resources: {}
  routePrefix: /
  selectAllByDefault: true
  templates:
  - key: monzo.tmpl
    name: vmalertmanager-<NAME>-vmstack-monzo-tpl

Resulting Secret snip:

templates:
- /etc/vm/configs/**/*.tmpl

I'm not a golang dev so I've used Claude to see why and it's suggested
https://github.com/VictoriaMetrics/operator/pull/1984/changes#diff-e10da433a249358d23e1aa8b27bcd1d7a010efccbe492ac7b19ef514271a5995R21
needs to also check for the presence of cr.Spec.Templates before deciding to exit:

  if len(pos.configs.All()) == 0 && cr.Spec.TracingConfig == nil && len(cr.Spec.Templates) == 0 {
      return data, nil                                                                                                                                                              
  }

We don't have any VMAlertmanagerConfig objects or tracing config

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions