Enable mypy pydantic plugin

Author: jameshilliard

.pre-commit-config.yaml

@@ -35,7 +35,12 @@ repos:
     rev: v1.18.2
     hooks:
       - id: mypy
-        additional_dependencies: [types-pyyaml==6.0.12.20250915]
+        additional_dependencies:
+          [
+            pydantic==2.11.9,
+            pydantic-settings==2.10.1,
+            types-pyyaml==6.0.12.20250915,
+          ]
   - repo: local
     hooks:
       - id: pytest

goosebit/api/v1/devices/device/responses.py

@@ -2,13 +2,7 @@
 
 from pydantic import BaseModel
 
-from goosebit.schema.devices import DeviceSchema
-
 
 class DeviceLogResponse(BaseModel):
     log: str | None
     progress: int | None
-
-
-class DeviceResponse(DeviceSchema):
-    pass

goosebit/api/v1/devices/device/routes.py

@@ -3,11 +3,12 @@
 from fastapi import APIRouter, Depends, HTTPException, Security
 from fastapi.requests import Request
 
-from goosebit.api.v1.devices.device.responses import DeviceLogResponse, DeviceResponse
+from goosebit.api.v1.devices.device.responses import DeviceLogResponse
 from goosebit.auth import validate_user_permissions
 from goosebit.auth.permissions import GOOSEBIT_PERMISSIONS
 from goosebit.db import Device
 from goosebit.device_manager import get_device
+from goosebit.schema.devices import DeviceSchema
 
 router = APIRouter(prefix="/{dev_id}")
 
@@ -16,11 +17,11 @@
     "",
     dependencies=[Security(validate_user_permissions, scopes=[GOOSEBIT_PERMISSIONS["device"]["read"]()])],
 )
-async def device_get(_: Request, device: Device = Depends(get_device)) -> DeviceResponse:
+async def device_get(_: Request, device: Device = Depends(get_device)) -> DeviceSchema:
     if device is None:
         raise HTTPException(404)
     await device.fetch_related("assigned_software", "hardware")
-    return DeviceResponse.model_validate(device)
+    return DeviceSchema.model_validate(device)
 
 
 @router.get(

goosebit/api/v1/rollouts/routes.py

@@ -29,12 +29,12 @@ async def rollouts_put(_: Request, rollout: RolloutsPutRequest) -> RolloutsPutRe
     software = await Software.filter(id=rollout.software_id)
     if len(software) == 0:
         raise HTTPException(404, f"No software with ID {rollout.software_id} found")
-    rollout = await Rollout.create(
+    created_rollout = await Rollout.create(
         name=rollout.name,
         feed=rollout.feed,
         software_id=rollout.software_id,
     )
-    return RolloutsPutResponse(success=True, id=rollout.id)
+    return RolloutsPutResponse(success=True, id=created_rollout.id)
 
 
 @router.patch(

goosebit/settings/schema.py

@@ -74,6 +74,8 @@ class StorageSettings(BaseModel):
 class GooseBitSettings(BaseSettings):
     model_config = SettingsConfigDict(env_prefix="GOOSEBIT_", extra="ignore", env_nested_delimiter="__")
 
+    config_file: Path | None = None
+
     port: int = 60053  # GOOSE
     tenant: str = "DEFAULT"
 

pyproject.toml

@@ -77,6 +77,12 @@ src_folder = "./goosebit"
 
 [tool.mypy]
 explicit_package_bases = true
+plugins = ["pydantic.mypy"]
+
+[tool.pydantic-mypy]
+init_forbid_extra = true
+init_typed = true
+warn_required_dynamic_aliases = true
 
 [tool.djlint]
 ignore = "H030,H031,H021"