Add cleanup of screen processes in unit tests

Author: chapterjason

.github/workflows/ci.yml

@@ -101,6 +101,6 @@ jobs:
                     tools: infection
             -   uses: ramsey/composer-install@v3
             -   run: |
-                    infection --min-msi=32 --min-covered-msi=59 "--threads=$(nproc)"
+                    infection --min-msi=33 --min-covered-msi=59 "--threads=$(nproc)"
                 env:
                     STRYKER_DASHBOARD_API_KEY: ${{ secrets.STRYKER_DASHBOARD_API_KEY }}

src/Manager/ScreenManager.php

@@ -87,7 +87,7 @@ public function start(ScreenInterface|string $nameOrScreen): bool
         return $process->isSuccessful();
     }
 
-    protected function resolveScreen(ScreenInterface|string $nameOrScreen): ScreenInterface
+    public function resolveScreen(ScreenInterface|string $nameOrScreen): ScreenInterface
     {
         if (\is_string($nameOrScreen)) {
             if (!$this->provider->has($nameOrScreen)) {
@@ -115,7 +115,7 @@ public function isRunning(ScreenInterface|string $nameOrScreen): bool
         return str_contains($process->getOutput(), $screenName);
     }
 
-    private function generateScreenName(ScreenInterface $screen): string
+    public function generateScreenName(ScreenInterface $screen): string
     {
         return hash('sha256', \sprintf('%s%s%s', $this->getBaseDirectory(), $screen->getName(), implode('', $screen->getCommand())));
     }

tests/Manager/ScreenManagerTest.php

@@ -8,14 +8,21 @@
 use SoureCode\Bundle\Screen\Factory\ScreenFactory;
 use SoureCode\Bundle\Screen\Manager\ScreenManager;
 use SoureCode\Bundle\Screen\Model\Screen;
+use SoureCode\Bundle\Screen\Model\ScreenInterface;
 use SoureCode\Bundle\Screen\Provider\ArrayScreenProvider;
 use Symfony\Component\Filesystem\Filesystem;
+use Symfony\Component\Process\Process;
 
 class ScreenManagerTest extends TestCase
 {
     private const int TIMEOUT_SECONDS = 5;
     private const int SLEEP_MICROSECONDS = 100;
 
+    /**
+     * @var string[] $screenNames
+     */
+    private array $screenNames = [];
+
     private function getScreenManager(string $randomEcho, int $randomSleep): ScreenManager
     {
         $factory = new ScreenFactory(Screen::class);
@@ -31,13 +38,41 @@ private function getScreenManager(string $randomEcho, int $randomSleep): ScreenM
         $filesystem = new Filesystem();
         $logger = new NullLogger();
 
-        return new ScreenManager(
+        $screenManager = new ScreenManager(
             realpath(__DIR__.'/../app'),
             'test',
             $filesystem,
             $screenProvider,
             $logger,
         );
+
+        /**
+         * @var ScreenInterface[] $screens
+         */
+        $screens = [];
+        $screens[] = $screenManager->resolveScreen('echoTest');
+        $screens[] = $screenManager->resolveScreen('daemonTest');
+
+        foreach ($screens as $screen) {
+            $this->screenNames[] = $screenManager->generateScreenName($screen);
+        }
+
+        return $screenManager;
+    }
+
+    private function clearScreens(): void
+    {
+        foreach ($this->screenNames as $screenName) {
+            $killProcess = new Process(['screen', '-S', $screenName, '-X', 'quit']);
+            $killProcess->run();
+        }
+
+        $this->screenNames = [];
+    }
+
+    protected function tearDown(): void
+    {
+        $this->clearScreens();
     }
 
     public function testStartAndLogs(): void