I don't think this works properly with cf-time variables, and think that it will silently fail by providing incorrect times. I think its worth updating the docstring and also adding a check (if the calendar in the metadata isn't supported (ie. is CF specific) raise a NotImplementedError) since this is quite a user facing function.
Originally posted by @VeckoTheGecko in #2607 (comment)
I don't think this works properly with cf-time variables, and think that it will silently fail by providing incorrect times. I think its worth updating the docstring and also adding a check (if the calendar in the metadata isn't supported (ie. is CF specific) raise a
NotImplementedError) since this is quite a user facing function.Originally posted by @VeckoTheGecko in #2607 (comment)