feat: Add --prop for contact properties (#50)

Co-authored-by: Nate Meyer <672246+notnmeyer@users.noreply.github.com>

Author: danrowden

cmd/contacts.go

@@ -27,6 +27,7 @@ func addContactFieldFlags(cmd *cobra.Command) {
 	cmd.Flags().StringP("subscribed", "s", "", `Subscribed status ("true" or "false")`)
 	cmd.Flags().String("user-group", "", "User group")
 	cmd.Flags().StringArray("list", nil, "Mailing list subscription as id=true|false (repeatable)")
+	cmd.Flags().StringArray("prop", nil, "Contact property as KEY=value (repeatable)")
 	cmd.Flags().String("contact-props", "", "Path to a JSON file of contact properties")
 }
 
@@ -70,6 +71,12 @@ func contactFieldParamsFromCmd(cmd *cobra.Command) (contactFieldParams, error) {
 		}
 		params.ContactProperties = contactProps
 	}
+	propPairs, _ := cmd.Flags().GetStringArray("prop")
+	props, err := cmdutil.ParseKeyValuePairs("prop", propPairs, params.ContactProperties)
+	if err != nil {
+		return params, err
+	}
+	params.ContactProperties = props
 
 	return params, nil
 }

cmd/contacts_create_test.go

@@ -110,6 +110,37 @@ func TestContactFieldParamsFromCmd(t *testing.T) {
 		}
 	})
 
+	t.Run("valid --prop", func(t *testing.T) {
+		cmd := newFieldCmd(t)
+		cmd.Flags().Set("prop", "plan=pro")
+		cmd.Flags().Set("prop", "score=42")
+		params, err := contactFieldParamsFromCmd(cmd)
+		if err != nil {
+			t.Fatalf("unexpected error: %v", err)
+		}
+		if params.ContactProperties["plan"] != "pro" || params.ContactProperties["score"] != "42" {
+			t.Errorf("unexpected contact properties: %v", params.ContactProperties)
+		}
+	})
+
+	t.Run("prop overrides contact-props file", func(t *testing.T) {
+		f := filepath.Join(t.TempDir(), "props.json")
+		os.WriteFile(f, []byte(`{"plan":"starter","region":"us"}`), 0644)
+		cmd := newFieldCmd(t)
+		cmd.Flags().Set("contact-props", f)
+		cmd.Flags().Set("prop", "plan=pro")
+		params, err := contactFieldParamsFromCmd(cmd)
+		if err != nil {
+			t.Fatalf("unexpected error: %v", err)
+		}
+		if params.ContactProperties["plan"] != "pro" {
+			t.Errorf("expected plan=pro, got %v", params.ContactProperties["plan"])
+		}
+		if params.ContactProperties["region"] != "us" {
+			t.Errorf("expected region=us, got %v", params.ContactProperties["region"])
+		}
+	})
+
 	t.Run("nonexistent --contact-props returns error", func(t *testing.T) {
 		cmd := newFieldCmd(t)
 		cmd.Flags().Set("contact-props", "/nonexistent/path.json")
@@ -118,6 +149,15 @@ func TestContactFieldParamsFromCmd(t *testing.T) {
 			t.Fatal("expected error, got nil")
 		}
 	})
+
+	t.Run("invalid --prop returns error", func(t *testing.T) {
+		cmd := newFieldCmd(t)
+		cmd.Flags().Set("prop", "missingequals")
+		_, err := contactFieldParamsFromCmd(cmd)
+		if err == nil {
+			t.Fatal("expected error, got nil")
+		}
+	})
 }
 
 func TestRunContactsCreate(t *testing.T) {

cmd/transactional.go

@@ -23,17 +23,7 @@ func parseDataVars(vars []string, jsonFile string) (map[string]any, error) {
 			return nil, err
 		}
 	}
-	for _, pair := range vars {
-		idx := strings.IndexByte(pair, '=')
-		if idx < 0 {
-			return nil, fmt.Errorf("--var %q: expected KEY=value", pair)
-		}
-		if m == nil {
-			m = make(map[string]any)
-		}
-		m[pair[:idx]] = pair[idx+1:]
-	}
-	return m, nil
+	return cmdutil.ParseKeyValuePairs("var", vars, m)
 }
 
 func attachmentFromPath(path string) (api.Attachment, error) {

internal/cmdutil/parse.go

@@ -4,8 +4,23 @@ import (
 	"encoding/json"
 	"fmt"
 	"os"
+	"strings"
 )
 
+func ParseKeyValuePairs(flag string, pairs []string, dst map[string]any) (map[string]any, error) {
+	for _, pair := range pairs {
+		idx := strings.IndexByte(pair, '=')
+		if idx < 0 {
+			return nil, fmt.Errorf("--%s %q: expected KEY=value", flag, pair)
+		}
+		if dst == nil {
+			dst = make(map[string]any)
+		}
+		dst[pair[:idx]] = pair[idx+1:]
+	}
+	return dst, nil
+}
+
 func ParseJSONFile(flag, path string) (map[string]any, error) {
 	data, err := os.ReadFile(path)
 	if err != nil {