fix(deps): replace glob with node native glob

Author: rubiesonthesky

package.json

@@ -45,7 +45,6 @@
 		"chalk": "5.6.2",
 		"commander": "14.0.3",
 		"enquirer": "2.4.1",
-		"glob": "13.0.6",
 		"ts-api-utils": "2.5.0"
 	},
 	"devDependencies": {

pnpm-lock.yaml

@@ -20,4 +20,10 @@ describe("collectFileNames", () => {
 			`At least one path including node_modules was included implicitly: '${cwd}/node_modules'. Either adjust TypeStat's included files to not include node_modules (recommended) or explicitly include node_modules/ (not recommended).`,
 		);
 	});
+
+	it("should NOT return error if node_modules are explicitly included", async () => {
+		const cwd = path.resolve(import.meta.dirname, "..");
+		const fileNames = await collectFileNames(cwd, ["node_modules"]);
+		expect(fileNames?.length).toBeGreaterThan(0);
+	});
 });

src/collectFileNames.test.ts

@@ -1,18 +1,17 @@
-import { glob } from "glob";
-import * as path from "node:path";
+import path from "node:path";
+import { glob } from "node:fs/promises";
 
 export const collectFileNames = async (
 	cwd: string,
 	include: readonly string[] | undefined,
 ): Promise<readonly string[] | string | undefined> => {
-	const globsAndNames = await collectFileNamesFromGlobs(cwd, include);
-	if (!globsAndNames) {
+	if (include === undefined) {
 		return undefined;
 	}
 
-	const [fileGlobs, fileNames] = globsAndNames;
+	const fileNames = await collectFileNamesFromGlobs(cwd, include);
 	const implicitNodeModulesInclude = implicitNodeModulesIncluded(
-		fileGlobs,
+		include,
 		fileNames,
 	);
 
@@ -25,24 +24,21 @@ export const collectFileNames = async (
 
 const collectFileNamesFromGlobs = async (
 	cwd: string,
-	include: readonly string[] | undefined,
-): Promise<[readonly string[], readonly string[]] | undefined> => {
-	if (include === undefined) {
-		return undefined;
+	include: readonly string[],
+): Promise<readonly string[]> => {
+	let fileNames: string[] = [];
+	for await (const entry of glob(include, { cwd, withFileTypes: true })) {
+		fileNames.push(path.join(entry.parentPath, entry.name));
 	}
-
-	return [
-		include,
-		await glob(include.map((subInclude) => path.join(cwd, subInclude))),
-	];
+	return fileNames;
 };
 
 const implicitNodeModulesIncluded = (
 	fileGlobs: readonly string[],
-	fileNames: readonly string[] | undefined,
-) => {
+	fileNames: readonly string[],
+): boolean => {
 	return (
 		!fileGlobs.some((glob) => glob.includes("node_modules")) &&
-		fileNames?.find((fileName) => fileName.includes("node_modules"))
+		fileNames.some((fileName) => fileName.includes("node_modules"))
 	);
 };

src/collectFileNames.ts

@@ -0,0 +1,12 @@
+import { describe, expect, it } from "vitest";
+import { getTsConfigPaths } from "./index.js";
+
+describe("getTsConfigPaths", () => {
+	it("should collect list of tsconfig files", async () => {
+		const cwd = process.cwd();
+		const fileNames = await getTsConfigPaths();
+		expect(fileNames).toHaveLength(2);
+		expect(fileNames).toContain(`${cwd}/tsconfig.eslint.json`);
+		expect(fileNames).toContain(`${cwd}/tsconfig.json`);
+	});
+});

src/initialization/initializeProject/index.spec.ts

@@ -1,6 +1,7 @@
 import enquirer from "enquirer";
-import * as fs from "fs";
-import { glob } from "glob";
+import { existsSync } from "node:fs";
+import { glob } from "node:fs/promises";
+import path from "node:path";
 
 import { uniquify } from "../../shared/arrays.js";
 import { initializeNewProject } from "./initializeNewProject.js";
@@ -32,7 +33,7 @@ const initializeBuiltInProject = async () => {
 		...uniquify(
 			TSConfigLocation.Root,
 			TSConfigLocation.UnderSrc,
-			...(await glob(["./tsconfig*json", "./*/tsconfig*json"])),
+			...(await getTsConfigPaths()),
 		),
 		TSConfigLocationSuggestion.Custom,
 		TSConfigLocationSuggestion.DoesNotExist,
@@ -47,7 +48,7 @@ const initializeBuiltInProject = async () => {
 			initial: Math.max(
 				0,
 				[TSConfigLocation.Root, TSConfigLocation.UnderSrc].findIndex((choice) =>
-					fs.existsSync(choice),
+					existsSync(choice),
 				),
 			),
 			type: "select",
@@ -57,6 +58,15 @@ const initializeBuiltInProject = async () => {
 	return project;
 };
 
+export const getTsConfigPaths = async (): Promise<string[]> => {
+	const cwd = process.cwd();
+	let fileNames: string[] = [];
+	for await (const entry of glob(["./tsconfig*json", "./*/tsconfig*json"])) {
+		fileNames.push(path.join(cwd, entry));
+	}
+	return fileNames;
+};
+
 const initializeCustomProject = async (): Promise<ProjectDescription> => {
 	const { project } = await prompt<{ project: string }>([
 		{

src/initialization/initializeProject/index.ts

@@ -1,6 +1,6 @@
 import { TextInsertMutation } from "automutate";
-import { glob } from "glob";
-import * as path from "node:path";
+import path from "node:path";
+import { globSync } from "node:fs";
 import ts from "typescript";
 
 import {
@@ -58,7 +58,7 @@ const visitExportOrImportDeclaration = (
 
 	for (const filePath of [basePath, path.join(basePath, "index")]) {
 		// If no files exist under that path, ignore this possibility
-		const possibilities = glob.sync(filePath + ".*");
+		const possibilities = globSync(filePath + ".*");
 		if (possibilities.length === 0) {
 			continue;
 		}