Handle CreateWhipPeerConnection returning a nil PeerConnection

Sean-Der · Sean-Der · commit d8d44018edbc · 2026-02-15T12:16:36.000-05:00
diff --git a/internal/webrtc/whip.go b/internal/webrtc/whip.go
@@ -24,9 +24,11 @@ func WHIP(offer string, profile authorization.PublicProfile) (sdp string, sessio
 	}
 
 	peerConnection, err := peerconnection.CreateWhipPeerConnection(offer)
-	if err != nil {
+	if err != nil || peerConnection == nil {
 		log.Println("WHIP.CreateWhipPeerConnection.Failed", err)
-		peerConnection.Close()
+		if peerConnection != nil {
+			peerConnection.Close()
+		}
 		return "", "", err
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -24,9 +24,11 @@ func WHIP(offer string, profile authorization.PublicProfile) (sdp string, sessio`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`peerConnection, err := peerconnection.CreateWhipPeerConnection(offer)`
`27`		`- if err != nil {`
	`27`	`+ if err != nil \|\| peerConnection == nil {`
`28`	`28`	`log.Println("WHIP.CreateWhipPeerConnection.Failed", err)`
`29`		`- peerConnection.Close()`
	`29`	`+ if peerConnection != nil {`
	`30`	`+ peerConnection.Close()`
	`31`	`+ }`
`30`	`32`	`return "", "", err`
`31`	`33`	`}`
`32`	`34`