Skip to content

Commit 604e702

Browse files
committed
Remove .golangci config
Custom config was causing us to ignore errors
1 parent 724e110 commit 604e702

3 files changed

Lines changed: 6 additions & 24 deletions

File tree

.golangci.yml

Lines changed: 0 additions & 22 deletions
This file was deleted.

internal/server/handlers/whep_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ type whepWebhookPayload struct {
1919
func TestWhepHandlerCallsWebhook(t *testing.T) {
2020
payloads := make(chan whepWebhookPayload, 1)
2121
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
22-
defer r.Body.Close()
22+
defer func() {
23+
_ = r.Body.Close()
24+
}()
2325

2426
var payload whepWebhookPayload
2527
if err := json.NewDecoder(r.Body).Decode(&payload); err != nil {

internal/webrtc/whip.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ func WHIP(offer string, profile authorization.PublicProfile) (sdp string, sessio
2727
if err != nil || peerConnection == nil {
2828
log.Println("WHIP.CreateWhipPeerConnection.Failed", err)
2929
if peerConnection != nil {
30-
peerConnection.Close()
30+
if closeErr := peerConnection.Close(); closeErr != nil {
31+
log.Println("WHIP.CreateWhipPeerConnection.Close.Failed", closeErr)
32+
}
3133
}
3234
return "", "", err
3335
}

0 commit comments

Comments
 (0)