Merge pull request #95 from GeneralUserModels/omar/feature-flags

Omar/feature flags

Author: oshaikh13

site/src/App.tsx

@@ -1,4 +1,4 @@
-import { type ReactNode, useEffect, useState } from "react";
+import React, { type ReactNode, useEffect, useState } from "react";
 
 const REPO = "GeneralUserModels/tada";
 const RELEASE_URL = `https://github.com/${REPO}/releases/latest`;

site/src/main.tsx

@@ -1,4 +1,4 @@
-import { StrictMode } from "react";
+import React, { StrictMode } from "react";
 import { createRoot } from "react-dom/client";
 import { App } from "./App";
 import "./App.css";

src/apps/moments/discovery.py

@@ -7,6 +7,8 @@
 from datetime import datetime
 from pathlib import Path
 
+from server.feature_flags import is_enabled
+
 logger = logging.getLogger(__name__)
 
 
@@ -100,7 +102,7 @@ async def run_moments_discovery(state) -> None:
                 logger.info("Next discovery run at %s (in %.0fs)", next_run, delay)
                 await asyncio.sleep(delay)
 
-            if not state.config.moments_enabled:
+            if not (is_enabled(state.config, "moments") and state.config.moments_enabled):
                 continue
 
             cfg = state.config

src/apps/moments/scheduler.py

@@ -12,6 +12,7 @@
 
 from apps.moments.execute import run as execute_moment, _parse_frontmatter as parse_frontmatter
 from apps.moments.state import load_state
+from server.feature_flags import is_enabled
 
 logger = logging.getLogger(__name__)
 
@@ -138,7 +139,7 @@ async def run_moments_scheduler(state) -> None:
         try:
             await asyncio.sleep(SCAN_INTERVAL)
 
-            if not state.config.moments_enabled:
+            if not (is_enabled(state.config, "moments") and state.config.moments_enabled):
                 continue
 
             cfg = state.config

src/client/renderer/App.tsx

@@ -1,4 +1,6 @@
+import React from "react";
 import { useAppContext } from "./context/AppContext";
+import { useFeatureFlag } from "./featureFlags";
 import { Sidebar } from "./components/Sidebar";
 import { ConnectorsView } from "./components/views/ConnectorsView";
 import { UserModelView } from "./components/views/UserModelView";
@@ -8,6 +10,7 @@ import { UpdateBanner } from "./components/UpdateBanner";
 
 export function App() {
   const { state, dispatch } = useAppContext();
+  const momentsEnabled = useFeatureFlag("moments");
 
   const navigate = (view: typeof state.activeView) => {
     dispatch({ type: "NAVIGATE", view });
@@ -30,7 +33,7 @@ export function App() {
           />
         )}
         {state.activeView === "connectors" && <ConnectorsView />}
-        {state.activeView === "tada" && <TadaView />}
+        {state.activeView === "tada" && momentsEnabled && <TadaView />}
         {state.activeView === "usermodel" && <UserModelView />}
         {state.activeView === "settings" && <SettingsView />}
       </main>

src/client/renderer/components/Sidebar.tsx

@@ -1,4 +1,6 @@
+import React from "react";
 import { ActiveView } from "../context/AppContext";
+import { useFeatureFlags, getFlag } from "../featureFlags";
 
 interface Props {
   activeView: ActiveView;
@@ -48,7 +50,19 @@ const navItems: { view: ActiveView; label: string; icon: JSX.Element }[] = [
   },
 ];
 
+const FLAG_FOR_VIEW: Partial<Record<ActiveView, string>> = {
+  tada: "moments",
+};
+
 export function Sidebar({ activeView, connected, onNavigate }: Props) {
+  const featureFlags = useFeatureFlags();
+
+  const visibleItems = navItems.filter(({ view }) => {
+    const flag = FLAG_FOR_VIEW[view];
+    if (flag && !getFlag(featureFlags, flag)) return false;
+    return true;
+  });
+
   return (
     <nav id="sidebar">
       <div className="sidebar-brand">
@@ -72,7 +86,7 @@ export function Sidebar({ activeView, connected, onNavigate }: Props) {
       </div>
 
       <div className="sidebar-nav">
-        {navItems.map(({ view, label, icon }) => (
+        {visibleItems.map(({ view, label, icon }) => (
           <button
             key={view}
             className={`nav-item${activeView === view ? " active" : ""}`}

src/client/renderer/components/UpdateBanner.tsx

@@ -1,3 +1,5 @@
+import React from "react";
+
 const DOWNLOAD_URL = "https://github.com/GeneralUserModels/tada-release/releases/latest";
 
 interface Props {

src/client/renderer/components/connectors/ConnectorItem.tsx

@@ -1,4 +1,4 @@
-import { useEffect, useState } from "react";
+import React, { useEffect, useState } from "react";
 
 const CONNECTOR_ICONS: Record<string, JSX.Element> = {
   monitor: (

src/client/renderer/components/dashboard/PipelineTile.tsx

@@ -1,3 +1,4 @@
+import React from "react";
 import { TrainingState } from "../../hooks/useTraining";
 
 const stateLabels: Record<TrainingState, string> = {

src/client/renderer/components/dashboard/PredictionCard.tsx

@@ -1,3 +1,5 @@
+import React from "react";
+
 interface Props {
   prediction: { actions?: string; error?: string; timestamp?: string } | null;
 }