From b90a1fd27e2ac7d7bd89ad9af30656827ff85abf Mon Sep 17 00:00:00 2001 From: Sahil Date: Mon, 18 May 2026 10:40:23 +0530 Subject: [PATCH 1/2] fix: test_unit_routers.py for ci/cd --- api/tests/unit/app/test_unit_app_routers.py | 37 ++++++++++----------- 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/api/tests/unit/app/test_unit_app_routers.py b/api/tests/unit/app/test_unit_app_routers.py index f2505c0d5ecc..4005fd7df162 100644 --- a/api/tests/unit/app/test_unit_app_routers.py +++ b/api/tests/unit/app/test_unit_app_routers.py @@ -1,6 +1,7 @@ import pytest +from unittest import mock from django.db import models - +from django.db.models.options import Options from app import routers @@ -16,14 +17,13 @@ def test_analytics_router_db_for_read__given_app_label__returns_expected_db( expected_db: str | None, ) -> None: # Given - class AnalyticsModel(models.Model): - class Meta: - app_label = given_app_label - + mock_model = mock.MagicMock(spec=models.Model) + mock_model._meta = mock.MagicMock(spec=Options) + mock_model._meta.app_label = given_app_label router = routers.AnalyticsRouter() # When - db = router.db_for_read(AnalyticsModel) + db = router.db_for_read(mock_model) # Then assert db == expected_db @@ -41,14 +41,13 @@ def test_analytics_router_db_for_write__given_app_label__returns_expected_db( expected_db: str | None, ) -> None: # Given - class MyModel(models.Model): - class Meta: - app_label = model_app_label - + mock_model = mock.MagicMock(spec=models.Model) + mock_model._meta = mock.MagicMock(spec=Options) + mock_model._meta.app_label = model_app_label router = routers.AnalyticsRouter() # When - db = router.db_for_write(MyModel) + db = router.db_for_write(mock_model) # Then assert db == expected_db @@ -67,18 +66,16 @@ def test_analytics_router_allow_relation__given_app_labels__returns_expected( expected: bool | None, ) -> None: # Given - class MyModel1(models.Model): - class Meta: - app_label = model1_app_label - - class MyModel2(models.Model): - class Meta: - app_label = model2_app_label - + mock_instance1 = mock.MagicMock(spec=models.Model) + mock_instance1._meta = mock.MagicMock(spec=Options) + mock_instance1._meta.app_label = model1_app_label + mock_instance2 = mock.MagicMock(spec=models.Model) + mock_instance2._meta = mock.MagicMock(spec=Options) + mock_instance2._meta.app_label = model2_app_label router = routers.AnalyticsRouter() # When - result = router.allow_relation(MyModel1(), MyModel2()) + result = router.allow_relation(mock_instance1, mock_instance2) # Then assert result == expected From 6d6282a57d0523b01a7c27862cccb5953f885782 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 19 May 2026 10:59:32 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- api/tests/unit/app/test_unit_app_routers.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/api/tests/unit/app/test_unit_app_routers.py b/api/tests/unit/app/test_unit_app_routers.py index 4005fd7df162..1fe9a8d18901 100644 --- a/api/tests/unit/app/test_unit_app_routers.py +++ b/api/tests/unit/app/test_unit_app_routers.py @@ -1,7 +1,9 @@ -import pytest from unittest import mock + +import pytest from django.db import models from django.db.models.options import Options + from app import routers