Skip to content

Proxy setting restore seems broken #264

@kannes

Description

@kannes

if self.http_proxy is not None:
os.environ["http_proxy"] = self.http_proxy
os.environ["http_proxy"] = self.http_proxy
else:
os.environ.pop("http_proxy", None)
os.environ.pop("https_proxy", None)

The line os.environ["http_proxy"] = self.http_proxy appears twice:

os.environ["http_proxy"] = self.http_proxy

while the https_proxy environment variable is not restored.

It should probably rather read:

if self.http_proxy is not None: 
     os.environ["http_proxy"] = self.http_proxy 
else: 
     os.environ.pop("http_proxy", None) 
if self.https_proxy is not None:
     os.environ["https_proxy"] = self.https_proxy 
else:
     os.environ.pop("https_proxy", None) 

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions